Skip to content

[Observability Onboarding] Link all “Add data” buttons in observability to onboarding landing page#179459

Merged
thomheymann merged 2 commits intoelastic:feat/obs-onboarding-flowfrom
thomheymann:178944-onboarding-links
Mar 27, 2024
Merged

[Observability Onboarding] Link all “Add data” buttons in observability to onboarding landing page#179459
thomheymann merged 2 commits intoelastic:feat/obs-onboarding-flowfrom
thomheymann:178944-onboarding-links

Conversation

@thomheymann
Copy link
Copy Markdown
Contributor

@thomheymann thomheymann commented Mar 26, 2024

Resolves #178944

📓 Summary

All "Add data" links within Observability link to /app/observabilityOnboarding when on serverless observability.

✔️ Acceptance criteria

All "Add data" links within Observability link to /app/observabilityOnboarding when on serverless observability:

  • Infrastructure > Inventory
  • Infrastructure > Hosts

@thomheymann thomheymann changed the base branch from main to feat/obs-onboarding-flow March 26, 2024 16:26
@ghost
Copy link
Copy Markdown

ghost commented Mar 26, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@thomheymann thomheymann marked this pull request as ready for review March 26, 2024 17:02
@thomheymann thomheymann requested a review from a team as a code owner March 26, 2024 17:02
@thomheymann thomheymann requested a review from a team March 26, 2024 17:02
@kibana-ci
Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [3760983]

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann changed the title 178944 onboarding links [Observability Onboarding] Link all “Add data” buttons in observability to onboarding landing page Mar 26, 2024
@thomheymann thomheymann removed the request for review from a team March 27, 2024 09:29
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the question is still whether these should link to the general guide as well:

Screenshot 2024-03-27 at 15 12 19

Definitely out of scope for this issue though - let's capture that separately.

@flash1293
Copy link
Copy Markdown
Contributor

@thomheymann I think this can target main directly as it makes sense even without the new onboarding page

@thomheymann thomheymann merged commit 4b5c5a1 into elastic:feat/obs-onboarding-flow Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants