Upgrade EUI to v93.4.0 by cee-chen · Pull Request #178890 · elastic/kibana

cee-chen · 2024-03-18T17:00:41Z

v93.3.0⏩ v93.4.0

`v93.4.0`

Added the following properties to EuiButtonGroup's options configs: toolTipContent, toolTipProps, and title. These new properties allow wrapping buttons in EuiToolTips, and additionally customizing or disabling the native browser title tooltip. (#7461)
Enhanced EuiResizeObserver and useResizeObserver's performance to not trigger page reflows on resize event (#7575)
Updated EuiSuperUpdateButton to support custom button text via an optional children prop (#7576)

Bug fixes

Fixed EuiFlyout to not repeatedly remove/add a body class on resize (#7462)
Fixed EuiToast title text to wrap instead of overflowing out of the container (#7568)
Fixed a visual bug with EuiHeaderBreadcrumbs with popovers (#7580)

Deprecations

Deprecated euiPalettePositive and euiPaletteNegative in favour of a more culturally inclusive euiPaletteGreen and euiPaletteRed (#7570)
Deprecated all charts theme exports in favor of @elastic/charts exports: (#7572)
- Deprecated EUI_CHARTS_THEME_<DARK|LIGHT> in favor of <DARK|LIGHT>_THEME from @elastic/charts. (#7572)
- Deprecated EUI_SPARKLINE_THEME_PARTIAL in favor of useSparklineOverrides theme from the kibana charts plugin theme service.

Accessibility

Updated EuiModal to set an aria-modal attribute and a default dialog role (#7564)
Updated EuiConfirmModal to set a default alertdialog role (#7564)
Fixed EuiModal and EuiConfirmModal to properly trap Safari+VoiceOver's virtual cursor (#7564)

- cell actions was covering the click element - adding a `moveMouseTo` fixes the issue

- checkbox click is happening before datagrid is done loading which is causing the selection to unset

cee-chen · 2024-03-19T22:02:39Z

/ci

elasticmachine · 2024-03-19T23:21:28Z

Pinging @elastic/eui-team (EUI)

cee-chen · 2024-03-19T23:22:33Z

src/core/public/styles/_base.scss

@@ -1,6 +1,5 @@
 // Charts themes available app-wide
 @import '@elastic/charts/dist/theme';
-@import '@elastic/eui/src/themes/charts/theme';


@nickofthyme Would appreciate your help QAing this and confirming that the removed .echAnnotation CSS does not materially affect Kibana (see elastic/eui#7572 (review))

@cee-chen did a check around kibana and see no impact of removing these styles.

elasticmachine · 2024-03-19T23:22:38Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

e40pud

DE changes LGTM

cauemarcondes

Obs infra services LGTM

peteharverson

ML changes LGTM

jsanz

Dashboard and Map changes look good to me.

x-pack/test/security_solution_cypress/cypress/tasks/hosts/events.ts

semd

Security solution LGTM. only a NIT.

tsullivan

For SharedUX, chrome-browser service snapshot changes LGTM

nickofthyme

CO changes look good 👍🏼

kqualters-elastic · 2024-03-22T15:56:29Z

x-pack/plugins/security_solution/public/common/components/header_actions/header_actions.tsx

+  const ColumnSorting = useDataGridColumnSorting({
+    columns: myColumns,
+    sorting: sortedColumns,
+    schema: {},


not that it wasn't like this before, but this and the array below should be a stable reference probably

kibana-ci · 2024-03-22T18:06:11Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 6bd5dde

Failed CI Steps

Test Failures

[job] [logs] Defend Workflows Cypress Tests #5 / Automated Response Actions From alerts should have generated endpoint and rule should have generated endpoint and rule
[job] [logs] FTR Configs #4 / discover/group4 discover integration with runtime fields editor allows creation of a new field

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1428	1429	+1
`kubernetesSecurity`	199	200	+1
`maps`	1149	1150	+1
`visTypeVega`	309	310	+1
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`advancedSettings`	36.8KB	36.8KB	-1.0B
`apm`	3.2MB	3.2MB	-2.0B
`charts`	9.4KB	9.4KB	-8.0B
`exploratoryView`	180.0KB	180.0KB	-5.0B
`infra`	1.4MB	1.4MB	+1001.0B
`kubernetesSecurity`	210.0KB	211.0KB	+1008.0B
`maps`	2.9MB	2.9MB	+994.0B
`ml`	3.7MB	3.7MB	-12.0B
`profiling`	400.7KB	400.7KB	-1.0B
`securitySolution`	15.5MB	15.5MB	+268.0B
`telemetryManagementSection`	33.6KB	33.6KB	-1.0B
`visTypeVega`	1.8MB	1.8MB	+1010.0B
total			+4.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	405.2KB	405.1KB	-92.0B
`kbnUiSharedDeps-npmDll`	6.2MB	6.3MB	+8.4KB
`kbnUiSharedDeps-srcJs`	2.9MB	2.9MB	+1.0B
`observabilityShared`	61.5KB	61.5KB	-1.0B
total			+8.3KB

History

💚 Build #198564 succeeded bd7f59d
💚 Build #198410 succeeded 3283d76
💔 Build #198379 failed 95d557291da60bfe20581aecace3fe64e6c9d224
💔 Build #198101 failed 5f0faaf3500b393b34a2d336267891111cb9ee98
💔 Build #198079 failed ae8e5e562e372943cad704eff086397a30f6d6fe
💔 Build #198072 failed 3fd5184ee97368a0b1db549d15750b0afde81e60

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.14.0 labels Mar 18, 2024

cee-chen force-pushed the eui/v93.4.0 branch from 3fd5184 to aae67b5 Compare March 18, 2024 17:29

cee-chen added 7 commits March 19, 2024 09:39

Upgrade EUI to v93.4.0

8e2e7b7

Update deprecated EUI palettes to new culturally inclusive names

e951c36

[EuiBreadcrumb] Fix type import

d6c0cf5

[EuiDataGrid] Update useDataGridColumnSorting usage

dda2012

[charts] Remove deprecated theme sass import

669d65c

[EuiModal] Update snapshots from a11y changes

af723c9

[EuiHeaderBreadcrumbs] Update snapshot from CSS fixes

952fd7b

cee-chen force-pushed the eui/v93.4.0 branch from 5f0faaf to 95d5572 Compare March 19, 2024 19:43

cee-chen added 2 commits March 19, 2024 14:01

[Dashboard] Fix flaky/failing FTR test

9cf1771

- cell actions was covering the click element - adding a `moveMouseTo` fixes the issue

[Security Cypress] Harden flaky test clicks

b8005f3

cee-chen force-pushed the eui/v93.4.0 branch 2 times, most recently from dc405d2 to 4e3769a Compare March 19, 2024 22:00

[Security Cypress] Harden events selection further

3283d76

- checkbox click is happening before datagrid is done loading which is causing the selection to unset

cee-chen force-pushed the eui/v93.4.0 branch from 4e3769a to 3283d76 Compare March 19, 2024 22:02

cee-chen marked this pull request as ready for review March 19, 2024 23:21

cee-chen requested review from a team as code owners March 19, 2024 23:21

cee-chen requested a review from a team March 19, 2024 23:21

cee-chen requested review from a team as code owners March 19, 2024 23:21

cee-chen requested a review from a team as a code owner March 19, 2024 23:21

cee-chen requested a review from e40pud March 19, 2024 23:21

cee-chen commented Mar 19, 2024

View reviewed changes

botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Mar 19, 2024

Ikuni17 approved these changes Mar 19, 2024

View reviewed changes

pgayvallet approved these changes Mar 20, 2024

View reviewed changes

e40pud approved these changes Mar 20, 2024

View reviewed changes

cauemarcondes approved these changes Mar 20, 2024

View reviewed changes

peteharverson approved these changes Mar 20, 2024

View reviewed changes

jsanz approved these changes Mar 20, 2024

View reviewed changes

semd reviewed Mar 20, 2024

View reviewed changes

x-pack/test/security_solution_cypress/cypress/tasks/hosts/events.ts Outdated Show resolved Hide resolved

semd approved these changes Mar 20, 2024

View reviewed changes

cee-chen added 2 commits March 20, 2024 09:15

[PR feedback] Security Cypress screens constants

a8088f4

Merge remote-tracking branch 'upstream/main' into eui/v93.4.0

bd7f59d

ryankeairns approved these changes Mar 21, 2024

View reviewed changes

tsullivan approved these changes Mar 21, 2024

View reviewed changes

nickofthyme approved these changes Mar 21, 2024

View reviewed changes

Merge branch 'main' into eui/v93.4.0

1c4b1df

kqualters-elastic reviewed Mar 22, 2024

View reviewed changes

kqualters-elastic approved these changes Mar 22, 2024

View reviewed changes

[PR feedback] Make empty array/obj stable references

6bd5dde

cee-chen enabled auto-merge (squash) March 22, 2024 16:22

cee-chen merged commit 3a16585 into elastic:main Mar 22, 2024

cee-chen deleted the eui/v93.4.0 branch March 22, 2024 18:06

kibanamachine added the backport:skip This PR does not require backporting label Mar 22, 2024

thomheymann mentioned this pull request Mar 26, 2024

[Observability Onboarding] Link all “Add data” buttons in observability to onboarding landing page #179459

Merged

eokoneyo mentioned this pull request Jul 1, 2024

[Reporting] Text overflowing in reporting completed notifcation banner #178351

Closed

Conversation

cee-chen commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v93.4.0

Uh oh!

cee-chen commented Mar 19, 2024

Uh oh!

elasticmachine commented Mar 19, 2024

Uh oh!

cee-chen Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

nickofthyme Mar 25, 2024

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 19, 2024

Uh oh!

e40pud left a comment

Choose a reason for hiding this comment

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

jsanz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

semd left a comment

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

kqualters-elastic Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Mar 22, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

cee-chen commented Mar 18, 2024 •

edited

Loading

`v93.4.0`