Skip to content

[8.12] [RAM] Fix bug where select all rules bypasses filters (#176962)#177096

Merged
Zacqary merged 8 commits intoelastic:8.12from
Zacqary:backport/8.12/pr-176962
Mar 18, 2024
Merged

[8.12] [RAM] Fix bug where select all rules bypasses filters (#176962)#177096
Zacqary merged 8 commits intoelastic:8.12from
Zacqary:backport/8.12/pr-176962

Conversation

@Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Feb 15, 2024

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Zacqary Adam Xeper "}},{"branch":"8.12","label":"v8.12.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/176962","number":176962,"mergeCommit":{"message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com//pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506"}}]}] BACKPORT-->

## Summary

Fixes elastic#176867

A bug introduced in elastic#174954
bypassed most filters when using Select All on the Rules List. This was
because the names of the filter properties changed, and no longer
matched what the `useBulkEditSelect` hook was expecting.

Because all of these types were optional, it didn't trigger any type
errors.

This syncs up the type definitions with the new filter store hook, and
adds a functional test to make sure filters are working on bulk actions
when clicking the select all button.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit e136a93)
@Zacqary Zacqary added the backport This PR is a backport of another PR label Feb 15, 2024
@Zacqary Zacqary enabled auto-merge (squash) February 15, 2024 22:33
@ghost
Copy link

ghost commented Feb 15, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Zacqary
Copy link
Contributor Author

Zacqary commented Mar 18, 2024

@elasticmachine merge upstream

@Zacqary
Copy link
Contributor Author

Zacqary commented Mar 18, 2024

@elasticmachine merge upstream

@Zacqary Zacqary merged commit d5201bd into elastic:8.12 Mar 18, 2024
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB -13.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants