[RAM] Fix bug where select all rules bypasses filters#176962
Merged
Zacqary merged 3 commits intoelastic:mainfrom Feb 15, 2024
Merged
[RAM] Fix bug where select all rules bypasses filters#176962Zacqary merged 3 commits intoelastic:mainfrom
Zacqary merged 3 commits intoelastic:mainfrom
Conversation
Zacqary
added
release_note:fix
Team:ResponseOps
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Zacqary
requested review from
JiaweiWu and
umbopepato
and removed request for
JiaweiWu and
umbopepato
JiaweiWu
approved these changes
Feb 15, 2024
Contributor
JiaweiWu
left a comment
JiaweiWu
left a comment
There was a problem hiding this comment.
I tested it and seems to work as intended, LGTM!
Contributor
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Fixes elastic#176867 A bug introduced in elastic#174954 bypassed most filters when using Select All on the Rules List. This was because the names of the filter properties changed, and no longer matched what the `useBulkEditSelect` hook was expecting. Because all of these types were optional, it didn't trigger any type errors. This syncs up the type definitions with the new filter store hook, and adds a functional test to make sure filters are working on bulk actions when clicking the select all button. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e136a93)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Fixes elastic#176867 A bug introduced in elastic#174954 bypassed most filters when using Select All on the Rules List. This was because the names of the filter properties changed, and no longer matched what the `useBulkEditSelect` hook was expecting. Because all of these types were optional, it didn't trigger any type errors. This syncs up the type definitions with the new filter store hook, and adds a functional test to make sure filters are working on bulk actions when clicking the select all button. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e136a93)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 15, 2024
#177063) # Backport This will backport the following commits from `main` to `8.13`: - [[RAM] Fix bug where select all rules bypasses filters (#176962)](#176962) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Zacqary Adam Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-15T18:30:08Z","message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.13.0","v8.12.2","v8.14.0"],"title":"[RAM] Fix bug where select all rules bypasses filters","number":176962,"url":"https://github.com/elastic/kibana/pull/176962","mergeCommit":{"message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176962","number":176962,"mergeCommit":{"message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506"}}]}] BACKPORT--> Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Fixes elastic#176867 A bug introduced in elastic#174954 bypassed most filters when using Select All on the Rules List. This was because the names of the filter properties changed, and no longer matched what the `useBulkEditSelect` hook was expecting. Because all of these types were optional, it didn't trigger any type errors. This syncs up the type definitions with the new filter store hook, and adds a functional test to make sure filters are working on bulk actions when clicking the select all button. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e136a93)
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Fixes elastic#176867 A bug introduced in elastic#174954 bypassed most filters when using Select All on the Rules List. This was because the names of the filter properties changed, and no longer matched what the `useBulkEditSelect` hook was expecting. Because all of these types were optional, it didn't trigger any type errors. This syncs up the type definitions with the new filter store hook, and adds a functional test to make sure filters are working on bulk actions when clicking the select all button. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Zacqary
added a commit
that referenced
this pull request
Mar 18, 2024
#177096) # Backport This will backport the following commits from `main` to `8.12`: - [[RAM] Fix bug where select all rules bypasses filters (#176962)](#176962) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Zacqary Adam Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-15T18:30:08Z","message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.13.0","v8.12.2","v8.14.0"],"number":176962,"url":"https://github.com/elastic/kibana/pull/176962","mergeCommit":{"message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/177063","number":177063,"state":"MERGED","mergeCommit":{"sha":"4e45baaef0134a39c624b0bf770eb7b51a7725c9","message":"[8.13] [RAM] Fix bug where select all rules bypasses filters (#176962) (#177063)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.13`:\n- [[RAM] Fix bug where select all rules bypasses filters\n(#176962)](https://github.com/elastic/kibana/pull/176962)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Zacqary Adam\nXeper\",\"email\":\"Zacqary@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-02-15T18:30:08Z\",\"message\":\"[RAM]\nFix bug where select all rules bypasses filters (#176962)\\n\\n##\nSummary\\r\\n\\r\\nFixes #176867 \\r\\n\\r\\nA bug introduced in\nhttps://github.com//pull/174954\\r\\nbypassed most filters\nwhen using Select All on the Rules List. This was\\r\\nbecause the names\nof the filter properties changed, and no longer\\r\\nmatched what the\n`useBulkEditSelect` hook was expecting.\\r\\n\\r\\nBecause all of these\ntypes were optional, it didn't trigger any type\\r\\nerrors.\\r\\n\\r\\nThis\nsyncs up the type definitions with the new filter store hook,\nand\\r\\nadds a functional test to make sure filters are working on bulk\nactions\\r\\nwhen clicking the select all button.\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"e136a9318215d5913a5e957aec5d9ad0b8132506\",\"branchLabelMapping\":{\"^v8.14.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:ResponseOps\",\"Feature:Alerting/RulesManagement\",\"v8.13.0\",\"v8.12.2\",\"v8.14.0\"],\"title\":\"[RAM]\nFix bug where select all rules bypasses\nfilters\",\"number\":176962,\"url\":\"https://github.com/elastic/kibana/pull/176962\",\"mergeCommit\":{\"message\":\"[RAM]\nFix bug where select all rules bypasses filters (#176962)\\n\\n##\nSummary\\r\\n\\r\\nFixes #176867 \\r\\n\\r\\nA bug introduced in\nhttps://github.com//pull/174954\\r\\nbypassed most filters\nwhen using Select All on the Rules List. This was\\r\\nbecause the names\nof the filter properties changed, and no longer\\r\\nmatched what the\n`useBulkEditSelect` hook was expecting.\\r\\n\\r\\nBecause all of these\ntypes were optional, it didn't trigger any type\\r\\nerrors.\\r\\n\\r\\nThis\nsyncs up the type definitions with the new filter store hook,\nand\\r\\nadds a functional test to make sure filters are working on bulk\nactions\\r\\nwhen clicking the select all button.\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"e136a9318215d5913a5e957aec5d9ad0b8132506\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.13\",\"8.12\"],\"targetPullRequestStates\":[{\"branch\":\"8.13\",\"label\":\"v8.13.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.12\",\"label\":\"v8.12.2\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.14.0\",\"branchLabelMappingKey\":\"^v8.14.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/176962\",\"number\":176962,\"mergeCommit\":{\"message\":\"[RAM]\nFix bug where select all rules bypasses filters (#176962)\\n\\n##\nSummary\\r\\n\\r\\nFixes #176867 \\r\\n\\r\\nA bug introduced in\nhttps://github.com//pull/174954\\r\\nbypassed most filters\nwhen using Select All on the Rules List. This was\\r\\nbecause the names\nof the filter properties changed, and no longer\\r\\nmatched what the\n`useBulkEditSelect` hook was expecting.\\r\\n\\r\\nBecause all of these\ntypes were optional, it didn't trigger any type\\r\\nerrors.\\r\\n\\r\\nThis\nsyncs up the type definitions with the new filter store hook,\nand\\r\\nadds a functional test to make sure filters are working on bulk\nactions\\r\\nwhen clicking the select all button.\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"e136a9318215d5913a5e957aec5d9ad0b8132506\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>"}},{"branch":"8.12","label":"v8.12.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176962","number":176962,"mergeCommit":{"message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506"}}]}] BACKPORT--> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added
v8.12.3
and removed
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #176867
A bug introduced in #174954 bypassed most filters when using Select All on the Rules List. This was because the names of the filter properties changed, and no longer matched what the
useBulkEditSelecthook was expecting.Because all of these types were optional, it didn't trigger any type errors.
This syncs up the type definitions with the new filter store hook, and adds a functional test to make sure filters are working on bulk actions when clicking the select all button.
Checklist