[ML] Anomaly Detection: Fixes color of markers in Single Metric Viewer when there is sparse data#176303
Merged
walterra merged 1 commit intoelastic:mainfrom Feb 6, 2024
Merged
Conversation
walterra
added
bug
Contributor
|
Pinging @elastic/ml-ui (:ml) |
qn895
approved these changes
Feb 6, 2024
Member
|
Code LGTM 🎉 |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @walterra |
MichaelMarcialis
approved these changes
Feb 6, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2024
## Summary Fixes the colors of "value dots", the dots that are shown in the Single Metric Viewer when theres sparse data and not a continuous line. Before: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/7844bfa0-3a50-4088-869a-5a6fc366c0cd"> After: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/28fcaa1e-eed9-497b-8c1a-c824effd7c31"> ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 1a53845)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 6, 2024
…76303) (#176326) # Backport This will backport the following commits from `main` to `8.12`: - [[ML] Anomaly Detection: Fix `values-dots` colors (#176303)](#176303) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2024-02-06T16:45:19Z","message":"[ML] Anomaly Detection: Fix `values-dots` colors (#176303)\n\n## Summary\r\n\r\nFixes the colors of \"value dots\", the dots that are shown in the Single\r\nMetric Viewer when theres sparse data and not a continuous line.\r\n\r\nBefore:\r\n\r\n<img width=\"1112\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/7844bfa0-3a50-4088-869a-5a6fc366c0cd\">\r\n\r\nAfter:\r\n\r\n<img width=\"1112\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/28fcaa1e-eed9-497b-8c1a-c824effd7c31\">\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1a5384558d272da8d4c1441191609f626c251456","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Anomaly Detection","v8.13.0","v8.12.2"],"title":"[ML] Anomaly Detection: Fix `values-dots` colors","number":176303,"url":"https://github.com/elastic/kibana/pull/176303","mergeCommit":{"message":"[ML] Anomaly Detection: Fix `values-dots` colors (#176303)\n\n## Summary\r\n\r\nFixes the colors of \"value dots\", the dots that are shown in the Single\r\nMetric Viewer when theres sparse data and not a continuous line.\r\n\r\nBefore:\r\n\r\n<img width=\"1112\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/7844bfa0-3a50-4088-869a-5a6fc366c0cd\">\r\n\r\nAfter:\r\n\r\n<img width=\"1112\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/28fcaa1e-eed9-497b-8c1a-c824effd7c31\">\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1a5384558d272da8d4c1441191609f626c251456"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176303","number":176303,"mergeCommit":{"message":"[ML] Anomaly Detection: Fix `values-dots` colors (#176303)\n\n## Summary\r\n\r\nFixes the colors of \"value dots\", the dots that are shown in the Single\r\nMetric Viewer when theres sparse data and not a continuous line.\r\n\r\nBefore:\r\n\r\n<img width=\"1112\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/7844bfa0-3a50-4088-869a-5a6fc366c0cd\">\r\n\r\nAfter:\r\n\r\n<img width=\"1112\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/230104/28fcaa1e-eed9-497b-8c1a-c824effd7c31\">\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1a5384558d272da8d4c1441191609f626c251456"}},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
Contributor
|
This PR didn't make it on time to the latest build candidate of v8.12.1. Updating the labels. |
jloleysens
added a commit
that referenced
this pull request
Feb 7, 2024
* main: (224 commits) [Http] Replace `buildNr` with `buildSha` in static asset paths (#175898) [Ops] Fix GCS bucket access for future buildkite agents (#174756) [api-docs] 2024-02-07 Daily api_docs build (#176362) skip flaky suite (#176002) skip failing es promotion suite (#176359) [Cloud Security] [Grouping] Add URL Params support to the grouping components (#175749) chore(NA): update versions after v8.12.2 bump (#176309) chore(NA): update versions after v7.17.19 bump (#176313) skip failing test suite (#176352) [SLO] Enable burn rate alert by default during creation via UI (#176317) [Fleet] Add the uptime capability to observability projects (#176285) [Security Solution][Endpoint] Fix Manifest Manger so that it works with large (>10k) (#174411) [ResponseOps] Alert creation delay based on user definition (#175851) [data views] Default field formatters based on field meta values (#174973) [Cloud Security]Detection Rules counter on Rules Flyout (#176041) [Security Solution] Data Quality Dashboard persistence (#175673) [Ent Search] Connector client copy cleanup (#176290) [ML] Anomaly Detection: Adds actions menu to anomaly markers in Single Metric Viewer chart. (#175556) [ML] Anomaly Detection: Fix `values-dots` colors (#176303) [Fleet] Logstash Output - being compliant to RFC-952 (#176298) ...
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
## Summary Fixes the colors of "value dots", the dots that are shown in the Single Metric Viewer when theres sparse data and not a continuous line. Before: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/7844bfa0-3a50-4088-869a-5a6fc366c0cd"> After: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/28fcaa1e-eed9-497b-8c1a-c824effd7c31"> ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
peteharverson
changed the title
values-dots colors
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Fixes the colors of "value dots", the dots that are shown in the Single Metric Viewer when theres sparse data and not a continuous line. Before: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/7844bfa0-3a50-4088-869a-5a6fc366c0cd"> After: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/28fcaa1e-eed9-497b-8c1a-c824effd7c31"> ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Fixes the colors of "value dots", the dots that are shown in the Single Metric Viewer when theres sparse data and not a continuous line. Before: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/7844bfa0-3a50-4088-869a-5a6fc366c0cd"> After: <img width="1112" alt="image" src="https://github.com/elastic/kibana/assets/230104/28fcaa1e-eed9-497b-8c1a-c824effd7c31"> ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the colors of "value dots", the dots that are shown in the Single Metric Viewer when there's sparse data and not a continuous line.
Before:
After:
Checklist