[data views] Default field formatters based on field meta values

[mattkime]

Summary

Default field formatters based on field meta units data.

Note: the smallest unit our formatter will show is milliseconds which means micro and nanoseconds may round down to zero for smaller values. #176112

Closes: #82318

Mapping and doc setup for testing -

PUT my-index-000001

PUT my-index-000001/_mapping
{
    "properties": {
            "nanos": {
        "type": "long",
        "meta": {
          "unit": "nanos"
        }
      },
            "micros": {
        "type": "long",
        "meta": {
          "unit": "micros"
        }
      },
      "ms": {
        "type": "long",
        "meta": {
          "unit": "ms"
        }
      },
                  "second": {
        "type": "long",
        "meta": {
          "unit": "s"
        }
      },
                  "minute": {
        "type": "long",
        "meta": {
          "unit": "m"
        }
      },
                  "hour": {
        "type": "long",
        "meta": {
          "unit": "h"
        }
      },
                  "day": {
        "type": "long",
        "meta": {
          "unit": "d"
        }
      },
      "percent": {
        "type": "long",
        "meta": {
          "unit": "percent"
        }
      },
            "bytes": {
        "type": "long",
        "meta": {
          "unit": "byte"
        }
      }
    }
}

POST my-index-000001/_doc
{
  "nanos" : 1234.5,
  "micros" : 1234.5,
  "ms" : 1234.5,
  "second" : 1234.5,
  "minute" : 1234.5,
  "hour" : 1234.5,
  "day" : 1234.5,
  "percent" : 1234.5,
  "bytes" : 1234.5
}

[felixbarny]

I saw that you've removed the nanos formatter. I understand that there can be issues with the current formatting library. For example, 1 ns would be formatted as 0.00 ms. However, I think that we should still support nanos, and file an issue for this known limitation/bug. In observability, we'd like to map the span duration as nanos. However, we don't expect spans to have a duration of only a few nanoseconds. It's much more typical to have something in the millisecond or second magnitude. So we'd miss not having support for nanos.

[mattkime]

So you want nanosecond values to display as millisecond even if nanosecond values less than 10,000 are displayed as 0.00 ms?

[felixbarny]

I think that's better than not having a default formatter for nanoseconds by default, yes.

If this turns out to be a problem for a specific visualization, users can still change the formatting. This is just setting a default formatter if none has been configured explicitly. Did I get that right?

[mattkime]

Yes, thats correct. I'll restore the formatter

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[felixbarny]

Just a question on the test case, otherwise LGTM.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 4b3dde2

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dataViews	53	54	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
data	2583	2585	+2
dataViews	273	276	+3
total			+5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dataViews	48.4KB	48.9KB	+584.0B

Unknown metric groups

API count

id	before	after	diff
data	3235	3237	+2
dataViews	940	943	+3
total			+5

History

• 💛 Build #191216 was flaky 8206024
• 💔 Build #191213 failed fb06dd8
• 💔 Build #191204 failed b33b299
• 💔 Build #191179 failed d968ee9
• 💔 Build #190940 failed 3f0c356
• 💔 Build #190934 failed 0aafe84

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

[lukasolson]

This is awesome! Are there any docs we could update to make this feature known, as well as explain the units that will work here? I made the mistake of using min instead of m and was confused for a second when it wasn't working.

[mattkime]

@lukasolson I think I'll do docs as a follow up so this can get merged for the current release.