Skip to content

Fix bug where we would apply only visible selection during the search #169367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e40pud merged 1 commit into from
Oct 19, 2023
Merged

Fix bug where we would apply only visible selection during the search #169367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .../security_solution/public/common/components/toolbar/bulk_actions/alert_bulk_assignees.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import React, { memo, useCallback, useEffect, useMemo, useState } from 'react';
import { ALERT_WORKFLOW_ASSIGNEE_IDS } from '@kbn/rule-data-utils';
import type { UserProfileWithAvatar } from '@kbn/user-profile-components';
import { UserProfilesSelectable } from '@kbn/user-profile-components';
import { useGetUserProfiles } from '../../../../detections/containers/detection_engine/alerts/use_get_user_profiles';
import { useSuggestUsers } from '../../../../detections/containers/detection_engine/alerts/use_suggest_users';
import * as i18n from './translations';
import type { SetAlertAssigneesFunc } from './use_set_alert_assignees';
Expand Down Expand Up @@ -40,7 +41,7 @@ const BulkAlertAssigneesPanelComponent: React.FC<BulkAlertAssigneesPanelComponen

const [selectedAssignees, setSelectedAssignees] = useState<UserProfileWithAvatar[]>([]);

const existingAssigneesIds = useMemo(
const originalIds = useMemo(
() =>
intersection(
...alertItems.map(
Expand All @@ -50,20 +51,21 @@ const BulkAlertAssigneesPanelComponent: React.FC<BulkAlertAssigneesPanelComponen
),
[alertItems]
);

const { loading: isLoadingAssignedUserProfiles, userProfiles: assignedUserProfiles } =
useGetUserProfiles(originalIds);
useEffect(() => {
if (isLoadingUsers) {
if (isLoadingAssignedUserProfiles) {
return;
}
const assignees = userProfiles.filter((user) => existingAssigneesIds.includes(user.uid));
setSelectedAssignees(assignees);
}, [existingAssigneesIds, isLoadingUsers, userProfiles]);
setSelectedAssignees(assignedUserProfiles);
}, [assignedUserProfiles, isLoadingAssignedUserProfiles]);

const onAssigneesUpdate = useCallback(async () => {
const existingIds = existingAssigneesIds;
const updatedIds = selectedAssignees.map((user) => user?.uid);

const assigneesToAddArray = updatedIds.filter((uid) => !existingIds.includes(uid));
const assigneesToRemoveArray = existingIds.filter((uid) => !updatedIds.includes(uid));
const assigneesToAddArray = updatedIds.filter((uid) => !originalIds.includes(uid));
const assigneesToRemoveArray = originalIds.filter((uid) => !updatedIds.includes(uid));
if (assigneesToAddArray.length === 0 && assigneesToRemoveArray.length === 0) {
closePopoverMenu();
return;
Expand All @@ -87,7 +89,7 @@ const BulkAlertAssigneesPanelComponent: React.FC<BulkAlertAssigneesPanelComponen
alertItems,
clearSelection,
closePopoverMenu,
existingAssigneesIds,
originalIds,
onSubmit,
refetchQuery,
refresh,
Expand Down