Skip to content

Fix bug where we would apply only visible selection during the search#169367

Merged
e40pud merged 1 commit intoelastic:security/feature/alert-user-assignmentfrom
e40pud:security/feature/alert-user-assignment-selection-bug
Oct 19, 2023
Merged

Fix bug where we would apply only visible selection during the search#169367
e40pud merged 1 commit intoelastic:security/feature/alert-user-assignmentfrom
e40pud:security/feature/alert-user-assignment-selection-bug

Conversation

@e40pud
Copy link
Contributor

@e40pud e40pud commented Oct 19, 2023

Summary

Fixes the bug where we would apply only visible user profile selections instead of taking into account those which are not visible during the search within component.

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Oct 19, 2023
@e40pud e40pud self-assigned this Oct 19, 2023
@e40pud e40pud requested a review from a team as a code owner October 19, 2023 11:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud e40pud merged commit 6a89c84 into elastic:security/feature/alert-user-assignment Oct 19, 2023
@e40pud e40pud deleted the security/feature/alert-user-assignment-selection-bug branch October 19, 2023 11:08
@kibana-ci
Copy link

kibana-ci commented Oct 19, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #6 / ALL - Packs Global packs add proper shard to policies packs config
  • [job] [logs] Jest Tests #10 / BulkAlertAssigneesPanel it calls expected functions on submit when alerts have changed
  • [job] [logs] Jest Tests #10 / BulkAlertAssigneesPanel it calls expected functions on submit when nothing has changed
  • [job] [logs] Jest Tests #10 / BulkAlertAssigneesPanel it updates state correctly
  • [job] [logs] Jest Tests #13 / useAlertAssigneesActions should render the nested panel
  • [job] [logs] Jest Tests #10 / useBulkAlertAssigneesItems should call setAlertAssignees on submit
  • [job] [logs] Jest Tests #10 / useBulkAlertAssigneesItems should still render alert assignees panel when useSetAlertAssignees is null

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [4bfc3fb]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@e40pud e40pud mentioned this pull request Oct 19, 2023
e40pud added a commit that referenced this pull request Oct 19, 2023
## Summary

Fix broken tests introduced in
#169367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants