feat(slo): store search state in url#168528
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kdelemme |
|
Looks good. Have you considered placing the logic for |
I'll see how this works |
@CoenWarmer Are locators similar to state containers? Cause I have implemented something similar with state containers in the o11y rules page. In case it's relevant @kdelemme you can have a look at these PRs to checkout how I used state containers My initial inspiration was this PR |
|
IMO the state containers pattern is a little complex for what it aims to achieve. I've created a couple of locators which are a bit more simple here:
|
|
I've created an issue for adding the locator: #169101 |
Resolves #167899
🍒 Summary
This PR synchronizes the search bar with the url state, useful for bookmarking and sharing search filters.
I've also refactored the search bar to remove the possibility to unselect a sort option.
search.state.mov