Skip to content

[Actionable Observability] state containers for last response filtering#131300

Merged
mgiota merged 2 commits intoelastic:mainfrom
mgiota:131299_state_containers_for_last_response_filtering
May 2, 2022
Merged

[Actionable Observability] state containers for last response filtering#131300
mgiota merged 2 commits intoelastic:mainfrom
mgiota:131299_state_containers_for_last_response_filtering

Conversation

@mgiota
Copy link
Copy Markdown
Contributor

@mgiota mgiota commented May 1, 2022 •
edited
Loading

Fixes #131299

Screen.Recording.2022-05-02.at.00.39.48.mov

@mgiota mgiota self-assigned this May 1, 2022
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 1, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 389 392 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 439.3KB 440.3KB +1017.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

@mgiota mgiota marked this pull request as ready for review May 2, 2022 06:54
@mgiota mgiota requested a review from a team May 2, 2022 06:54
@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 release_note:skip Skip the PR/issue when compiling release notes labels May 2, 2022
simianhacker
simianhacker approved these changes May 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgiota mgiota merged commit 6278939 into elastic:main May 2, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 2, 2022
@mgiota mgiota deleted the 131299_state_containers_for_last_response_filtering branch May 10, 2022 08:48
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@mgiota @kertal
[Actionable Observability] state containers for last response filteri…
2689407 
…ng (elastic#131300)

* add lastResponse filtering in the urlbar using routeParams

* refactor using state containers
@emma-raffenne emma-raffenne mentioned this pull request Jul 26, 2022
Closed
2 tasks
@mgiota mgiota mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees

@mgiota mgiota

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Actionable Observability] [Rules Page] Sync Last response filtering with urlbar

4 participants

@mgiota @kibana-ci @simianhacker @kibanamachine