Skip to content

[feature] Implement Setting Categories in Advanced Settings in serverless#167447

Merged
clintandrewhall merged 6 commits intoelastic:mainfrom
clintandrewhall:advanced_settings/field_categories
Sep 28, 2023
Merged

[feature] Implement Setting Categories in Advanced Settings in serverless#167447
clintandrewhall merged 6 commits intoelastic:mainfrom
clintandrewhall:advanced_settings/field_categories

Conversation

@clintandrewhall
Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall commented Sep 27, 2023

Summary

This PR follows #166460 by adding Category panels to the Form.

Screenshot 2023-09-27 at 3 36 16 PM

Notes

This PR is divided into several commits, the first few being prerequisite codemods. I recommend reviewing each commit separately, as the codemods might obscure the actual component work.

@clintandrewhall clintandrewhall added review loe:medium Medium Level of Effort Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. ci:build-storybooks v8.11.0 labels Sep 27, 2023
@clintandrewhall clintandrewhall requested a review from a team as a code owner September 27, 2023 19:43
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@clintandrewhall clintandrewhall force-pushed the advanced_settings/field_categories branch from e0d91a5 to cc71151 Compare September 28, 2023 02:44
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @clintandrewhall! Thanks a lot for adding these fixes/improvements and the category component!

Tested the components in Storybook and everything looks good to me. Code changes also LGTM, I only left one minor comment.

Comment thread packages/kbn-management/settings/utilities/mocks/settings.mock.ts Outdated
@clintandrewhall clintandrewhall enabled auto-merge (squash) September 28, 2023 15:48
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-components-field-category - 3 +3
@kbn/management-settings-types 0 3 +3
@kbn/management-settings-utilities 2 6 +4
total +10
Unknown metric groups

API count

id before after diff
@kbn/management-settings-components-field-category - 23 +23
@kbn/management-settings-components-field-row 26 23 -3
@kbn/management-settings-types 75 81 +6
@kbn/management-settings-utilities 50 54 +4
total +30

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@clintandrewhall clintandrewhall merged commit 76b832e into elastic:main Sep 28, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:build-storybooks Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants