[feature] Implement Setting Categories in Advanced Settings in serverless#167447
Merged
clintandrewhall merged 6 commits intoelastic:mainfrom Sep 28, 2023
Merged
Conversation
Contributor
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
e0d91a5 to
cc71151
Compare
ElenaStoeva
approved these changes
Sep 28, 2023
Contributor
ElenaStoeva
left a comment
There was a problem hiding this comment.
Great work @clintandrewhall! Thanks a lot for adding these fixes/improvements and the category component!
Tested the components in Storybook and everything looks good to me. Code changes also LGTM, I only left one minor comment.
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows #166460 by adding Category panels to the Form.
Notes
This PR is divided into several commits, the first few being prerequisite codemods. I recommend reviewing each commit separately, as the codemods might obscure the actual component work.
SettingTypeoptional, to clean up areas where the generic need not be specific.onChangehandlers weren't very clear as you work your way up the component tree. This makes the implementation and usage easier to understand, (and easier to replace with state management).Monacoand from some missingactandwaitForcalls.