[serverless] Advanced Settings - Form component by ElenaStoeva · Pull Request #166460 · elastic/kibana

ElenaStoeva · 2023-09-14T13:29:26Z

Summary

This PR adds a package that contains a form component for the Advanced Settings UI in serverless.
This implementation was extracted from the the Form component in the advancedSettings plugin, excluding some functionalities:

The form doesn't support search queries.
The form doesn't divide the settings into categories.

Testing

The form can be tested in the Storybook Preview from the CI build. Some things to be tested:

Making changes to any of the fields displays the bottom bar.
Clicking the Cancel button clears the changes.
Clicking the Save button triggers a saveChanges action with the correct changes.
The bottom bar correctly shows the number of unsaved settings.
Toggling the isSavingEnabled control to false disables all fields.
Toggling the requirePageReload control to true causes saving of changes to any of the fields to trigger a showReloadPagePrompt action.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

clintandrewhall

This is great work...! Quick turnaround, too. Just a few nits/improvements. While we wait for the prerequisite to ship, I would take some time to document and add a few tests.

…va/kibana into advanced_settings/form

…-ref HEAD~1..HEAD --fix'

…fix'

elasticmachine · 2023-09-20T18:14:32Z

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

ElenaStoeva · 2023-09-22T09:45:55Z

@elasticmachine merge upstream

ElenaStoeva · 2023-09-22T12:48:24Z

@elasticmachine merge upstream

yuliacech

Amazing work, @ElenaStoeva! Code changes LGTM, also verified the form locally with storybook.

clintandrewhall

Awesome work...! I'm approving as well, but please address my comments before committing. Thanks for your work here!

ElenaStoeva · 2023-09-25T16:10:37Z

@elasticmachine merge upstream

ElenaStoeva · 2023-09-25T17:57:26Z

@elasticmachine merge upstream

ElenaStoeva · 2023-09-25T20:20:09Z

@elasticmachine merge upstream

kibana-ci · 2023-09-25T21:32:05Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #17

Test Failures

[job] [logs] FTR Configs #17 / serverless examples UI Partial Results Example "before all" hook for "should trace mouse events"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/management-settings-components-form`	-	2	+2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/management-settings-components-form`	-	3	+3

Unknown metric groups

API count

id	before	after	diff
`@kbn/management-settings-components-form`	-	8	+8

History

💔 Build #161970 failed d4e89b1
💔 Build #161903 failed 232d631
💚 Build #161181 succeeded dbed0c9
💔 Build #161146 failed 72230e1
💔 Build #161085 failed 1c40803

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

…less (#167447) ## Summary This PR follows #166460 by adding Category panels to the Form. <img width="1807" alt="Screenshot 2023-09-27 at 3 36 16 PM" src="https://github.com/elastic/kibana/assets/297604/2abe8cf5-5822-473f-affd-148fb7949316"> ## Notes This PR is divided into several commits, the first few being prerequisite codemods. I recommend reviewing each commit separately, as the codemods might obscure the actual component work. - [e78586f - Make SettingType pre-defined to clean up references](e78586f) - This makes the `SettingType` optional, to clean up areas where the generic need not be specific. - [80a9988 - [codemod] Make onFieldChange and onInputChange more distinct](80a9988) - The `onChange` handlers weren't very clear as you work your way up the component tree. This makes the implementation and usage easier to understand, (and easier to [replace with state management](#166579)). - [5d0beff - [fix] Fix logged errors in form tests](5d0beff) - This fixes some logged errors in the Form from `Monaco` and from some missing `act` and `waitFor` calls.

[serverless] Advanced Settings - Form component

b36f9e2

ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Sep 14, 2023

ElenaStoeva self-assigned this Sep 14, 2023

ElenaStoeva requested a review from clintandrewhall September 14, 2023 13:34

clintandrewhall reviewed Sep 14, 2023

View reviewed changes

Comment thread packages/kbn-management/settings/components/form/bottom_bar/index.tsx Outdated

Comment thread packages/kbn-management/settings/components/form/bottom_bar/index.tsx Outdated

clintandrewhall reviewed Sep 14, 2023

View reviewed changes

Comment thread packages/kbn-management/settings/components/form/form.tsx Outdated

clintandrewhall reviewed Sep 14, 2023

View reviewed changes

Comment thread packages/kbn-management/settings/components/form/services.tsx Outdated

ElenaStoeva added 2 commits September 18, 2023 13:00

Address feedback

ad18ae3

Add remaining form functionalities

0787f7a

ElenaStoeva force-pushed the advanced_settings/form branch from fafa3b3 to 0787f7a Compare September 18, 2023 18:11

ElenaStoeva mentioned this pull request Sep 18, 2023

[Advanced Settings] Build new page for serverless #160411

Closed

9 tasks

ElenaStoeva added 3 commits September 19, 2023 18:31

[serverless] Advanced Settings - Form component

8fb4359

Address feedback

1aa1584

Add remaining form functionalities

012e68b

ElenaStoeva force-pushed the advanced_settings/form branch from 0787f7a to 012e68b Compare September 19, 2023 17:31

ElenaStoeva added 2 commits September 19, 2023 18:36

Merge branch 'advanced_settings/form' of https://github.com/ElenaStoe…

0cbc386

…va/kibana into advanced_settings/form

Refactor changes, add initial tests

bdce1a5

ElenaStoeva force-pushed the advanced_settings/form branch from b9ea610 to bdce1a5 Compare September 19, 2023 18:17

clintandrewhall reviewed Sep 19, 2023

View reviewed changes

kibanamachine and others added 5 commits September 19, 2023 18:22

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

5ffebd2

…-ref HEAD~1..HEAD --fix'

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

359d9fa

…fix'

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

d79f977

Address feedback

75c941e

Add settings mock and fix types

cb9e357

ElenaStoeva force-pushed the advanced_settings/form branch from 0865caa to cb9e357 Compare September 20, 2023 07:23

kibanamachine and others added 4 commits September 20, 2023 07:30

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

46e5652

…fix'

Fix bottom bar tests

de2eb28

Add form tests

cefe38c

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

2f27856

…fix'

Add storybook control for requirePageReload

866d1d8

ElenaStoeva marked this pull request as ready for review September 20, 2023 18:14

ElenaStoeva requested a review from a team as a code owner September 20, 2023 18:14

ElenaStoeva added the Feature:uiSettings label Sep 20, 2023

ElenaStoeva changed the title ~~[WIP] [serverless] Advanced Settings - Form component~~ [serverless] Advanced Settings - Form component Sep 20, 2023

ElenaStoeva added 2 commits September 21, 2023 12:42

Refactor changes

a24ea1f

Fix skipped tests

f3d6c36

kibanamachine and others added 2 commits September 22, 2023 05:45

Merge branch 'main' into advanced_settings/form

1c40803

Small fix

72230e1

Merge branch 'main' into advanced_settings/form

dbed0c9

yuliacech approved these changes Sep 22, 2023

View reviewed changes

clintandrewhall approved these changes Sep 22, 2023

View reviewed changes

Address feedback

d67ccda

Merge branch 'main' into advanced_settings/form

232d631

kibanamachine and others added 2 commits September 25, 2023 13:57

Merge branch 'main' into advanced_settings/form

8100931

Fix bottom bar tests

d4e89b1

Merge branch 'main' into advanced_settings/form

302da22

ElenaStoeva merged commit fd1a1f9 into elastic:main Sep 26, 2023

kibanamachine added v8.11.0 backport:skip This PR does not require backporting labels Sep 26, 2023

ElenaStoeva deleted the advanced_settings/form branch September 27, 2023 11:43

clintandrewhall mentioned this pull request Sep 27, 2023

[feature] Implement Setting Categories in Advanced Settings in serverless #167447

Merged

Conversation

ElenaStoeva commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Checklist

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Sep 20, 2023

Uh oh!

ElenaStoeva commented Sep 22, 2023

Uh oh!

ElenaStoeva commented Sep 22, 2023

Uh oh!

yuliacech left a comment

Choose a reason for hiding this comment

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ElenaStoeva commented Sep 25, 2023

Uh oh!

ElenaStoeva commented Sep 25, 2023

Uh oh!

ElenaStoeva commented Sep 25, 2023

Uh oh!

kibana-ci commented Sep 25, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Public APIs missing exports

API count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ElenaStoeva commented Sep 14, 2023 •

edited

Loading