Skip to content

[ML] Transforms: Fix TS, remove hideFrozenDataTierChoice#167399

Closed
walterra wants to merge 1 commit intoelastic:mainfrom
walterra:ml-fix-hideFrozenDataTierChoice
Closed

[ML] Transforms: Fix TS, remove hideFrozenDataTierChoice#167399
walterra wants to merge 1 commit intoelastic:mainfrom
walterra:ml-fix-hideFrozenDataTierChoice

Conversation

@walterra
Copy link
Contributor

@walterra walterra commented Sep 27, 2023

Summary

Fixes #167396.

Fixes a TypeScript linting error, removes hideFrozenDataTierChoice from the transform creation wizard.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms Transforms v8.11.0 labels Sep 27, 2023
@walterra walterra self-assigned this Sep 27, 2023
@walterra walterra requested a review from a team as a code owner September 27, 2023 12:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra
Copy link
Contributor Author

walterra commented Sep 27, 2023

Output of local TS check:

❯ node scripts/type_check.js --project x-pack/plugins/transform/tsconfig.json
 info Building TypeScript projects to check types (For visible, though excessive, progress info you can pass --verbose)
 info starting [tsc] > node_modules/typescript/bin/tsc -b x-pack/plugins/transform/tsconfig.type_check.json --pretty
 info [tsc] exited with 0 after 10.1 seconds

@walterra
Copy link
Contributor Author

Closing in favour of #167396

@walterra walterra closed this Sep 27, 2023
@kibana-ci
Copy link

kibana-ci commented Sep 27, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #1 / fleet usage telemetry should fetch usage telemetry
  • [job] [logs] FTR Configs #4 / maps app embeddable maps add-to-dashboard save flow should allow existing maps be added by reference to an existing dashboard
  • [job] [logs] FTR Configs #19 / serverless security UI Cases List "before all" hook in "Cases List"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 401.1KB 400.8KB -245.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Transforms Transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants