chore(typecheck): clean up unused parameter

[delanni]

Summary

This unused parameter is causing typescript error in many builds:
https://buildkite.com/elastic/kibana-pull-request/builds/162839#018ad64e-f2db-4572-a2df-2a9257777077

proc [tsc] x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx:358:19 - error TS2322: Type '{ frozenDataPreference: FrozenTierPreference; setFrozenDataPreference: (value: FrozenTierPreference \| undefined) => void; dataView: DataView; query: undefined; disabled: false; timefilter: TimefilterContract; hideFrozenDataTierChoice: boolean; }' is not assignable to type 'IntrinsicAttributes & FullTimeRangeSelectorProps & { children?: ReactNode; }'.
--
  | proc [tsc]   Property 'hideFrozenDataTierChoice' does not exist on type 'IntrinsicAttributes & FullTimeRangeSelectorProps & { children?: ReactNode; }'.
  | proc [tsc]
  | proc [tsc] 358                   hideFrozenDataTierChoice={!showNodeInfo}

[walterra]

LGTM, thanks for taking care of this, this happened probably because of two overlapping PRs merged in parallel.

[delanni]

@walterra - indeed, that's what I uncovered from my investigations 🕵️‍♂️ I hope this is a good fix

[jgowdyelastic]

I'd like to replace this PR with one that fixes the types, but also fixes the functionality which is broken because of this error.
#167404
If that's ok?

---

Edit: we discussed this in the team and agreed that getting this PR in first to unblock CI is better.
So I'll update my PR once this is merged.

[delanni]

@jgowdyelastic - thanks, I tried to understand the behaviour, I thought it was a benign leftover, and the functionality is not broken.
Ultimately, I'll leave it up for your decision, it's your code. I would however agree, I think it's better to clean up main's type errors first to reduce noise for everyone.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 1845b5f

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
transform	401.1KB	400.8KB	-245.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream