[management] Adjustments to Settings components and utilities

[clintandrewhall]

Caveat: the functional flow logic we've adopted for these components is not one I would encourage, specifically, using "drilled" onChange handlers and utilizing a composing-component-based store. Ideally, we'd use a redux store, or, at the very least a React reducer.

In the interest of time and compatibility, we've opted to use the pattern from the original components in advancedSettings. We plan to revisit the state management and prop-drilling when advancedSettings is refactored with these components.

This PR is a prerequisite to #166319 and to completing the Advanced Settings page in Serverless.

Note: Github appears to be a bit confused in the diff comparison, due to the addition to React.forwardRef... apologies for the noise.

Summary

While working on #166319 I found a number of bugs when working against actual UI settings stored in Kibana. This PR addresses those issues without waiting for the Settings page to be complete:

• Refactors input components to have cleaner APIs, including unsavedChange and field "all the way down".
  • This cleans up confusing logic, and sets us up for Redux actions.
• Creates a normalizeSettings function.
  • Settings returned from the UiSettingsService in an actual deployment of Kibana are drastically unpredictable. In some cases, type is missing, but value is there... or value is missing entirely, but a userValue is there.
  • This function "normalizes" the data, deriving missing parts where possible.
• Changes the onChangeFn to accept undefined to indicate an unsaved change has been reverted, rather than relying on the value in the unsaved change.
  • This fixes a number of issues around resets and reverts.
• Alters the unsavedChange prop to be undefined, (to indicate the lack of an unsaved change), rather than an undefined value.
• Fixes an issue where the ImageFieldInput wasn't removing a file that had been set when resetting to default;
  • Adds an imperative ref to FieldInput components to reset a field's input beyond resetting the value, (if necessary).
• Fixes the Storybook common setups to allow for changes to the onChange types.
• Fixed a bug where the FieldRow was indexing an unsaved change by name, rather than by id.
• Fixed an issue where the reset link wasn't always clearing a change to the default value.
• Fixes an issue with the aria label not being derived properly using the query.
• Splits the utility functions into their respective namespaces: settings and fields.
• Adds a few more tests to the utility functions to catch logic errors.

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[ElenaStoeva]

Thank you for making these fixes and additions @clintandrewhall! Overall LGTM.

I only noticed some strange behaviour in the image field but I think some of it exists from before this PR. Approving the PR since these issues could be addressed in a separate one; plus, there are no image settings in serverless.

[vadimkibana]

Codeowners changes LGTM

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: c617afd
• Storybooks Preview

Failed CI Steps

• FTR Configs #14
• FTR Configs #35

Test Failures

• [job] [logs] FTR Configs #35 / EPM Endpoints Install endpoint package install should have installed the [endpoint.metadata_current-default] transform
• [job] [logs] FTR Configs #14 / serverless observability UI Create Case "before each" hook for "creates a case"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/management-settings-components-field-input	1	5	+4
@kbn/management-settings-components-field-row	2	7	+5
@kbn/management-settings-utilities	30	2	-28
total			-19

Unknown metric groups

API count

id	before	after	diff
@kbn/management-settings-components-field-row	11	26	+15
@kbn/management-settings-field-definition	42	45	+3
@kbn/management-settings-types	71	75	+4
@kbn/management-settings-utilities	39	50	+11
total			+33

History

• 💚 Build #159801 succeeded f9c5b38
• 💚 Build #159405 succeeded 458b02b980067cd3007aac3461d8a273e90fc4c8
• 💔 Build #159400 failed 20b412d86d7ca19c6e6c0a5893d73a3b9c8a3c76
• 💚 Build #158964 succeeded eccf55f7d41e4026e898d29528c7189a097c778b
• 💔 Build #158955 failed 8dfec6153f1c85dffbedbe9bd5ae214009f07e53

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream