Skip to content

[build/docker] Upgrade Ubuntu base image to 22.04#162282

Merged
jbudz merged 12 commits intoelastic:mainfrom
jbudz:build/docker-upgrade-ubuntu
Oct 23, 2023
Merged

[build/docker] Upgrade Ubuntu base image to 22.04#162282
jbudz merged 12 commits intoelastic:mainfrom
jbudz:build/docker-upgrade-ubuntu

Conversation

@jbudz
Copy link
Contributor

@jbudz jbudz commented Jul 19, 2023 •
edited
Loading

Release note:
revertedThe default container's base image has been upgraded from Ubuntu 20.04 to 22.04

@jbudz jbudz added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes ci:build-all-platforms ci:build-os-packages backport:all-open Backport to all branches that could still receive a release labels Jul 19, 2023
@jbudz jbudz added the ci:cloud-deploy Create or update a Cloud deployment label Jul 19, 2023
@jbudz jbudz added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:build-all-platforms ci:build-os-packages labels Jul 21, 2023
@jbudz
Copy link
Contributor Author

jbudz commented Jul 21, 2023

buildkite test this

@jbudz jbudz added ci:build-serverless-image and removed ci:cloud-redeploy Always create a new Cloud deployment labels Oct 18, 2023
@jbudz jbudz added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 18, 2023
@jbudz jbudz marked this pull request as ready for review October 18, 2023 20:11
@jbudz jbudz requested a review from a team as a code owner October 18, 2023 20:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 18, 2023

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz requested a review from legrego October 18, 2023 20:11
jbudz
jbudz commented Oct 18, 2023
View reviewed changes
src/dev/build/tasks/os_packages/docker_generator/templates/base/Dockerfile
# Generate a stub command that will be overwritten at runtime
RUN mkdir /app && \
echo -e '#!/bin/bash\nexec /usr/local/bin/kibana-docker' > /app/kibana.sh && \
/usr/bin/echo -e '#!/bin/bash\nexec /usr/local/bin/kibana-docker' > /app/kibana.sh && \
Copy link
Contributor Author

@jbudz jbudz Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for local testing and can be ignored, it's meant to be overwritten. RUN uses sh, which has a builtin echo that doesn't support the -e flag.

Ikuni17
Ikuni17 reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading Jon. The deployment images look fine. Think we need a doc update here:

kibana/docs/setup/docker.asciidoc

Line 13 in 8fd827f

base image is https://hub.docker.com/_/ubuntu[ubuntu:20.04].

Also, do you think this could be considered a breaking change for downstream users? Do users use the Kibana image as a base image?

@jbudz jbudz added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:cloud-deploy Create or update a Cloud deployment labels Oct 23, 2023
@kibana-ci
Copy link

kibana-ci commented Oct 23, 2023 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5605 +5605
total size - 5.9MB +5.9MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz added backport:prev-minor and removed backport:all-open Backport to all branches that could still receive a release labels Oct 23, 2023
@jbudz jbudz merged commit 9d139f6 into elastic:main Oct 23, 2023
@jbudz
Copy link
Contributor Author

jbudz commented Oct 23, 2023

I'm going to manually open a 7.17 backport, splitting off the docs changes to a separate pull request that's merged after the next 7.17 release. Will link in a moment.

@kibanamachine kibanamachine mentioned this pull request Oct 23, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 23, 2023
@jbudz
[build/docker] Upgrade Ubuntu base image to 22.04 (elastic#162282)
327779a 
Release note:
The default container's base image has been upgraded from Ubuntu 20.04
to 22.04

(cherry picked from commit 9d139f6)
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 23, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit to jbudz/kibana that referenced this pull request Oct 23, 2023
@jbudz
[build/docker] Upgrade Ubuntu base image to 22.04 (elastic#162282)
1771260 
Release note:
The default container's base image has been upgraded from Ubuntu 20.04
to 22.04
@jbudz jbudz mentioned this pull request Oct 23, 2023
Merged
@jbudz
Copy link
Contributor Author

jbudz commented Oct 23, 2023

7.17: #169581, and after releasing 7.17.15 update docs with #169582

kibanamachine added a commit that referenced this pull request Oct 23, 2023
@kibanamachine @jbudz
[8.11] [build/docker] Upgrade Ubuntu base image to 22.04 (#162282) (#…
a382569 
…169580)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[build/docker] Upgrade Ubuntu base image to 22.04
(#162282)](#162282)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2023-10-23T19:49:06Z","message":"[build/docker]
Upgrade Ubuntu base image to 22.04 (#162282)\n\nRelease note:\r\nThe
default container's base image has been upgraded from Ubuntu 20.04\r\nto
22.04","sha":"9d139f6192647a91010e95c84d651644158abc69","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Operations","backport:prev-minor","ci:cloud-redeploy","ci:build-serverless-image","v8.12.0"],"number":162282,"url":"https://github.com/elastic/kibana/pull/162282","mergeCommit":{"message":"[build/docker]
Upgrade Ubuntu base image to 22.04 (#162282)\n\nRelease note:\r\nThe
default container's base image has been upgraded from Ubuntu 20.04\r\nto
22.04","sha":"9d139f6192647a91010e95c84d651644158abc69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162282","number":162282,"mergeCommit":{"message":"[build/docker]
Upgrade Ubuntu base image to 22.04 (#162282)\n\nRelease note:\r\nThe
default container's base image has been upgraded from Ubuntu 20.04\r\nto
22.04","sha":"9d139f6192647a91010e95c84d651644158abc69"}}]}] BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
jbudz added a commit that referenced this pull request Oct 24, 2023
@jbudz
[7.17] [build/docker] Upgrade Ubuntu base image to 22.04 (#162282) (#…
c8260c3 
…169581)

Backports #162282, excluding the docs changes which need to go out after
release.
@jbudz jbudz added the v7.17.15 label Oct 24, 2023
jbudz added a commit to jbudz/kibana that referenced this pull request Nov 2, 2023
@jbudz
Revert "[8.11] [build/docker] Upgrade Ubuntu base image to 22.04 (ela…
cd6fe5e 
…stic#162282) (elastic#169580)"

This reverts commit a382569.
jbudz added a commit to jbudz/kibana that referenced this pull request Nov 2, 2023
@jbudz
Revert "[build/docker] Upgrade Ubuntu base image to 22.04 (elastic#16…
ab9852b 
…2282)"

This reverts commit 9d139f6.
jbudz added a commit to jbudz/kibana that referenced this pull request Nov 2, 2023
@jbudz
Revert "[7.17] [build/docker] Upgrade Ubuntu base image to 22.04 (ela…
ef45dfe 
…stic#162282) (elastic#169581)"

This reverts commit c8260c3.
@jbudz jbudz mentioned this pull request Nov 2, 2023
Closed
@jbudz jbudz added the reverted label Nov 2, 2023
@jbudz
Copy link
Contributor Author

jbudz commented Nov 2, 2023

There's issues starting node on hosts running older versions of Ubuntu.

node::WorkerThreadsTaskRunner::DelayedTaskScheduler::Start(): Assertion `(0) == (uv_thread_create(t.get(), start_thread, this))' failed.

@jbudz jbudz mentioned this pull request Nov 2, 2023
Merged
jbudz added a commit that referenced this pull request Nov 2, 2023
@jbudz
Revert "[build/docker] Upgrade Ubuntu base image to 22.04 (#162282)" (#…
8133f01 
…170430)

This reverts commit 9d139f6.
delanni pushed a commit to delanni/kibana that referenced this pull request Nov 6, 2023
@jbudz @delanni
Revert "[build/docker] Upgrade Ubuntu base image to 22.04 (elastic#16…
0bab82a 
…2282)" (elastic#170430)

This reverts commit 9d139f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legrego legrego legrego approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees

No one assigned

Labels

ci:build-serverless-image ci:cloud-redeploy Always create a new Cloud deployment release_note:enhancement reverted Team:Operations Kibana-Operations Team v7.17.15 v8.11.0 v8.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jbudz @elasticmachine @kibana-ci @kibanamachine @legrego @Ikuni17