Skip to content

Conversation

@1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Jul 7, 2023

[email protected]83.1.0


83.1.0

  • Added placeholder prop to EuiInlineEdit (#6883)
  • Added sparkles glyph to EuiIcon (#6898)

Bug fixes

  • Fixed Safari-only bug for single-line row EuiDataGrids, where cell actions on hover would overlap instead of pushing content to the left (#6881)
  • Fixed EuiButton not correctly merging in passed classNames with its base .euiButton class (#6887)
  • Fixed EuiIcon not correctly passing the style prop custom img icons (#6888)
  • Fixed multiple components with child props (e.g. buttonProps, iconProps, etc.) unsetting EUI's Emotion styling if custom css was passed to the child props object (#6896)

CSS-in-JS conversions

  • Converted EuiHeader and EuiHeaderLogo to Emotion (#6878)
  • Removed Sass variables $euiHeaderDarkBackgroundColor, $euiHeaderBorderColor, and $euiHeaderBreadcrumbColor (#6878)
  • Removed Sass mixin @euiHeaderDarkTheme (#6878)

@1Copenut 1Copenut self-assigned this Jul 7, 2023
@1Copenut 1Copenut added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting v8.9.0 v8.10.0 labels Jul 7, 2023
@1Copenut 1Copenut marked this pull request as ready for review July 10, 2023 19:55
@1Copenut 1Copenut requested a review from a team as a code owner July 10, 2023 19:55
@1Copenut 1Copenut requested a review from a team July 10, 2023 19:55
@1Copenut 1Copenut requested review from a team as code owners July 10, 2023 19:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsullivan may want to confirm the changes are passive to the new chrome.

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 298.8KB 296.4KB -2.4KB
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +5.1KB
total +2.7KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security changes LGTM

@1Copenut 1Copenut merged commit e58c455 into elastic:main Jul 11, 2023
@1Copenut 1Copenut deleted the eui/v83.1.0 branch July 11, 2023 20:51
@cee-chen cee-chen removed the v8.9.0 label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants