[EuiButton] Fix overridden (instead of merged) className
#6887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
fix-button-classname
branch
from
a735efc to
e320ee5
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6887/ |
breehall
approved these changes
Jun 29, 2023
Contributor
breehall
left a comment
breehall
left a comment
There was a problem hiding this comment.
It's very interesting that this slid under the radar! Great catch and fix.
❓ Will this impact many snapshots in Kibana since we're adding the euiButton class name back into the mix?
Comment on lines
-116
to
-117
| className="euiButton" | ||
| ref={buttonRef} |
Contributor
There was a problem hiding this comment.
Super interesting. I never noticed this!
Contributor
Author
Haha yup, I'm pretty sure it will 💀 Ah well, it do be that way. We're doing a bunch of Emotion conversions which affect snapshots anyway, so might as well get it fixed |
1Copenut
added a commit
to elastic/kibana
that referenced
this pull request
Jul 11, 2023
`[email protected]` ⏩ `83.1.0` --- ## [`83.1.0`](https://github.com/elastic/eui/tree/v83.1.0) - Added `placeholder` prop to `EuiInlineEdit` ([#6883](elastic/eui#6883)) - Added `sparkles` glyph to `EuiIcon` ([#6898](elastic/eui#6898)) **Bug fixes** - Fixed Safari-only bug for single-line row `EuiDataGrid`s, where cell actions on hover would overlap instead of pushing content to the left ([#6881](elastic/eui#6881)) - Fixed `EuiButton` not correctly merging in passed `className`s with its base `.euiButton` class ([#6887](elastic/eui#6887)) - Fixed `EuiIcon` not correctly passing the `style` prop custom `img` icons ([#6888](elastic/eui#6888)) - Fixed multiple components with child props (e.g. `buttonProps`, `iconProps`, etc.) unsetting EUI's Emotion styling if custom `css` was passed to the child props object ([#6896](elastic/eui#6896)) **CSS-in-JS conversions** - Converted `EuiHeader` and `EuiHeaderLogo` to Emotion ([#6878](elastic/eui#6878)) - Removed Sass variables `$euiHeaderDarkBackgroundColor`, `$euiHeaderBorderColor`, and `$euiHeaderBreadcrumbColor` ([#6878](elastic/eui#6878)) - Removed Sass mixin `@euiHeaderDarkTheme` ([#6878](elastic/eui#6878))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This bug was introduced during Caroline's Emotion conversion of EuiButton (which was merged in without thorough QA after she left). At least I presume it's a bug and not intentional, no other component's
classNamebehaves this way.(Bug discovered during
shouldRenderCustomStyleswork, pulling it out to its own PR for easy review and a separate changelog)QA
General checklist
and cypress tests