Skip to content

[Fleet] Support for Profiling symbolization #155115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockdaboot merged 2 commits into from
Apr 19, 2023
Merged

[Fleet] Support for Profiling symbolization #155115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15fc55
[Fleet] Support for Universal Profiling data streams and indices
rockdaboot Apr 18, 2023
ca2cefa
[Fleet] Support for Universal Profiling hidden indices
rockdaboot Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions x-pack/plugins/fleet/server/services/api_keys/logstash_api_keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export async function canCreateLogstashApiKey(esClient: ElasticsearchClient) {
'synthetics-*-*',
'.logs-endpoint.diagnostic.collection-*',
'.logs-endpoint.action.responses-*',
'profiling-*-*',
'profiling-*',
'.profiling-*',
],
privileges: ['auto_configure', 'create_doc'],
},
Expand Down Expand Up @@ -59,7 +60,8 @@ export async function generateLogstashApiKey(esClient: ElasticsearchClient) {
'synthetics-*-*',
'.logs-endpoint.diagnostic.collection-*',
'.logs-endpoint.action.responses-*',
'profiling-*-*',
'profiling-*',
'.profiling-*',
],
privileges: ['auto_configure', 'create_doc'],
},
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/fleet/server/services/data_streams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import type { IndicesDataStream, IndicesIndexTemplate } from '@elastic/elasticsearch/lib/api/types';
import type { ElasticsearchClient } from '@kbn/core/server';

const DATA_STREAM_INDEX_PATTERN = 'logs-*-*,metrics-*-*,traces-*-*,synthetics-*-*,profiling-*-*';
const DATA_STREAM_INDEX_PATTERN = 'logs-*-*,metrics-*-*,traces-*-*,synthetics-*-*,profiling-*';
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, this pattern is used to query for data streams so that they show in Fleet > Data streams

do you know if this is something profiling wants? if profiling data streams/indices should be viewed and managed elsewhere, maybe we need to remove it here

Copy link
Copy Markdown
Contributor Author

@rockdaboot rockdaboot Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far we considered this OK. But trying to get more opinions from the team...

Copy link
Copy Markdown
Contributor

@jen-huang jen-huang Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, glad that it was considered already. this is an easy change to make down the road


class DataStreamService {
public async getAllFleetDataStreams(esClient: ElasticsearchClient) {
Expand Down