[Fleet] Support for Profiling symbolization#155115
Merged
rockdaboot merged 2 commits intoelastic:mainfrom Apr 19, 2023
Merged
Conversation
rockdaboot
added
release_note:skip
botelastic
Bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kpollich
approved these changes
Apr 18, 2023
jen-huang
reviewed
Apr 18, 2023
| import type { ElasticsearchClient } from '@kbn/core/server'; | ||
|
|
||
| const DATA_STREAM_INDEX_PATTERN = 'logs-*-*,metrics-*-*,traces-*-*,synthetics-*-*,profiling-*-*'; | ||
| const DATA_STREAM_INDEX_PATTERN = 'logs-*-*,metrics-*-*,traces-*-*,synthetics-*-*,profiling-*'; |
Contributor
There was a problem hiding this comment.
BTW, this pattern is used to query for data streams so that they show in Fleet > Data streams
do you know if this is something profiling wants? if profiling data streams/indices should be viewed and managed elsewhere, maybe we need to remove it here
Contributor
Author
There was a problem hiding this comment.
So far we considered this OK. But trying to get more opinions from the team...
Contributor
There was a problem hiding this comment.
ok, glad that it was considered already. this is an easy change to make down the road
jen-huang
approved these changes
Apr 18, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Universal Profiling data stream and index pattern from
profiling-*-*toprofiling-*in the fleet-server and logstash key generator.Additionally, there is a second commit to add the
.profiling-*index pattern.We use this for ILM / roll-over of the k/v indices, but want to hide these type of indices from the user.
See also: https://docs.google.com/document/d/1yTQXOlxW-L0rSueqUbL1IrX-VxAVFLZ-X6ySb5RSlrM/edit