fix(slo): fulltext search on name #154666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kdelemme
force-pushed
the
slo/fix-list-page
branch
from
e994bd7 to
5db74d9
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kdelemme |
Contributor
|
I see now. @pgayvallet we can't sort by name anymore due to this fix. Are there plans to reintroduce this at some point? |
CoenWarmer
approved these changes
Apr 11, 2023
Contributor
CoenWarmer
left a comment
CoenWarmer
left a comment
There was a problem hiding this comment.
Code changes look good. Shame about the loss of functionality but that's outside of our control.
pgayvallet
approved these changes
Apr 11, 2023
Contributor
pgayvallet
left a comment
pgayvallet
left a comment
There was a problem hiding this comment.
Thank you for the fix (and sorry for breaking your stuff!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #154659
This PR introduces a fix for searching through the SLO names since the SO mapping has been changed to "text". We cannot sort by name anymore, so I replaced it by creation time.