Skip to content

Conversation

@pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Apr 5, 2023

Summary

Fix #154244
Related / workaround for #130616

Very old issue that happened again, this time for the slo type because of mapping incompatibilities with default searchable fields (and a limitation in our code we still did not address)

  • Fix the slo SO type mapping for the name field (keyword => text)
  • Add a integration test failing if any management type has incorrect mappings for searchable fields (mostly a workaround rather than fixing the root problem, but at least it will avoid that kind of scenario for the time being)

@pgayvallet pgayvallet added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes Feature:Saved Objects Management v8.8.0 labels Apr 5, 2023
@pgayvallet pgayvallet changed the title add test for that Fix SO management fulltext search Apr 5, 2023
@pgayvallet
Copy link
Contributor Author

@elasticmachine merge upstream

@pgayvallet pgayvallet force-pushed the kbn-154244-default-search-field-again branch from 1cd238a to 7e3bf80 Compare April 5, 2023 09:56
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review April 5, 2023 13:43
@pgayvallet pgayvallet requested review from a team as code owners April 5, 2023 13:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ideally, we should fix the actual bug that forces all name to be text instead of anything else.

@pgayvallet
Copy link
Contributor Author

Ideally, we should fix the actual bug that forces all name to be text instead of anything else

Yeah, for sure, this isn't fixing the root cause. But it fixes the bug in 8.8.

FWIW I took a shot a long time ago at fixing it properly in #119618, but it was more complicated than I anticipated. I don't remember the details, unfortunately

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @pgayvallet!

@pgayvallet pgayvallet merged commit 8de96ea into elastic:main Apr 6, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 6, 2023
@kdelemme
Copy link
Contributor

This bug fix seems to break the SLO page. Opening an issue to track it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Saved Objects Management release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search by name is not working on Saved Objects page

7 participants