-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Fix SO management fulltext search #154409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SO management fulltext search #154409
Conversation
|
@elasticmachine merge upstream |
…search-field-again
1cd238a to
7e3bf80
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ideally, we should fix the actual bug that forces all name to be text instead of anything else.
Yeah, for sure, this isn't fixing the root cause. But it fixes the bug in 8.8. FWIW I took a shot a long time ago at fixing it properly in #119618, but it was more complicated than I anticipated. I don't remember the details, unfortunately |
CoenWarmer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @pgayvallet!
|
This bug fix seems to break the SLO page. Opening an issue to track it |
Summary
Fix #154244
Related / workaround for #130616
Very old issue that happened again, this time for the
slotype because of mapping incompatibilities with default searchable fields (and a limitation in our code we still did not address)sloSO type mapping for thenamefield (keyword => text)