[Fleet] Fix warning icon not displaying on 8.7#154119
Merged
Conversation
With EUI v76, `warning` icon type was introduced: #152506 However, the EUI upgrade was only applied on 8.8. The callout here that uses the warning icon was backported to 8.7, where the EUI version does not have the `warning` icon type. Thus 8.7 should still use the legacy `alert` icon type. This PR fixes that and will only be merged into 8.7.
jen-huang
added
release_note:fix
backport:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
jlind23
approved these changes
Mar 31, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @jen-huang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally reported in #152234 (comment)
With EUI v76,
warningicon type was introduced: #152506However, the EUI upgrade was only applied on 8.8. The callout here that uses the warning icon was a bug fix backported to 8.7 after the EUI upgrade. In 8.7 the EUI version does not have the
warningicon type, causing a broken image to be rendered in this callout.This PR reverts the icon to the legacy
alerttype will only be merged into 8.7.