Upgraded EUI to v76.0.0 #152506

JasonStoltz · 2023-03-01T20:23:31Z

👋 Hi all - the biggest breaking change of this PR is around two icon type changes/renames.

⚠️ The alert icon is now named warning
- This change should have been automatically converted on your behalf by the EUI team, but if for some reason we missed making this conversion in this PR and your icon(s) are now broken, please ping us or let us know in this PR (or fix yourself after this PR merges).
- In some cases, teams were using this icon for error messages, alongside the danger color. In those cases, we opinionatedly changed those icon usages to the new error icon instead of using the old alert/warning icon.
🛑 The crossInACircleFilled icon has been removed, and a new error icon added
- The conversion for this breaking change was not straightforward. This was the path we used to determine what to change crossInACircleFilled usages to:
  - If the icon was associated with errors or error messages, we changed it to the new error icon.
  - If a "delete" action was associated with this icon, we changed it to the trash icon instead.
  - If a "clear" action was associated with this icon, we changed it to just the cross icon, or in some cases minusInCircleFilled (if used alongside plusInCircleFilled).
- Again, if we made a mistake during this conversion or missed your plugin, please feel free to ping us.

Summary

[email protected] ⏩ [email protected]

`76.0.2`

Bug fixes

Added a legacy alert alias for the warning EuiIcon type (#6640)

`76.0.1`

Bug fixes

Fixed broken icons on all isInvalid form controls (#6629)

`76.0.0`

Added pivot glyph to EuiIcon (#6605)
Added the displayHeaderCellProps API to EuiDataGrid's columns, which allows passing custom props directly to column header cells (#6609)
Added the new headerCellProps/footerCellProps APIs to EuiDataGrid's control columns, which allows passing custom props directly to control column header or footer cells (#6609)
Added a new footerCellRender API to EuiDataGrid's control columns, which allows completely customizing control column rendering (previously rendered an empty cell) (#6609)
Updated the styling of nested ordered lists in EuiText to align with GitHub's list style, which is a popular format used in Markdown or MDX formatting (#6615)
Added a margin-bottom property exclusively to the direct child ul and ol elements of the EuiText component (#6615)
Fix issue with badges appearing within an EuiBadgeGroup, where the CSS rule to override the margin-inline-start was not being applied correctly due to the order of appearance in the CSS rules (#6618)

Bug fixes

Fixed EuiDataGrid footer control columns rendering with cell expansion popovers when they should not have been (#6609)
Fixed an EuiSkipLink bug where main content loading in progressively/dynamically after the skip link rendered was not being correctly focused (#6613)

Breaking changes

Renamed EuiIcon's alert to warning (#6608)
Removed EuiIcon's crossInACircleFilled in favor of error (#6608)

elasticmachine · 2023-03-06T13:14:42Z

Pinging @elastic/eui-design (EUI)

azasypkin · 2023-03-06T15:40:53Z

Breaking changes
Renamed EuiIcon's alert to warning (elastic/eui#6608)

@JasonStoltz won't it break many places in Kibana or alert is still considered a valid icon type for backward-compatibility?

cee-chen · 2023-03-06T17:01:06Z

@JasonStoltz won't it break many places in Kibana or alert is still considered a valid icon type for backward-compatibility?

@azasypkin is correct, we need to update all instances of type="alert" or iconType="alert" (or variable usages) to warning as part of this PR. @miukimiu or @daveyholler would either of you be able to help with that?

daveyholler · 2023-03-06T17:43:17Z

@cee-chen I'll take that.

JasonStoltz · 2023-03-06T20:20:47Z

Sorry ya'll, totally missed that.

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

- Errors -> `error` - Delete actions -> `trash` - Clear actions -> `cross` or `minusInCircleFilled` (if used alongside `plusInCircleFilled`)

…olor to use new `error` icon instead

daveyholler

Lookin' good. I dig it.

- fix missing renames

cee-chen · 2023-03-08T23:50:48Z

@elasticmachine merge upstream

kc13greiner

LGTM!

justinkambic

Synthetics changes LGTM!

cee-chen · 2023-03-09T17:25:36Z

@elasticmachine merge upstream

cee-chen · 2023-03-10T00:00:12Z

Pinging all remaining CODEOWNERS:

@elastic/sec-cloudnative-integrations @elastic/security-detections-response @elastic/security-solution-platform @elastic/security-detections-response @elastic/security-solution-platform @elastic/security-detections-response-alerts @elastic/security-detections-response-rules @elastic/security-threat-hunting-explore @elastic/security-threat-hunting-investigations @elastic/appex-sharedux @elastic/kibana-visualizations @elastic/response-ops @elastic/protections-experience @elastic/infra-monitoring-ui @elastic/fleet @elastic/apm-ui

We've determined any failing or flaky tests are unrelated to our EUI changes (after rerunning / merging latest multiple times, the tests that fail/succeed change each time), and will be asking Kibana Ops to admin merge this PR by Friday EOD. If you could take a second to review your owned files before then, we would hugely appreciate it. If not, and you notice any issues (primarily around the breaking changes of the new warning and error icons), you should be able to fix them after this PR merges and well before the next feature freeze.

cauemarcondes

Profiling changes LGTM

nchaulet

Fleet changes LGTM

michaelolo24

Investigations changes. LGTM!

drewdaemon

Visualizations changes look good.

I tested importing an 8.6 visualization with alert icons and they remained unchanged. The other icon substitutions make sense.

cee-chen · 2023-03-14T18:04:52Z

@elasticmachine merge upstream

kibana-ci · 2023-03-14T18:34:40Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detection rules, bulk edit of rule actions Restricted action privileges User with no privileges can't add rule actions
[job] [logs] Threat Intelligence Tests #4 / Indicators Indicators timeline interactions should add entry in timeline when clicking in an indicator flyout overview block
[job] [logs] Threat Intelligence Tests #4 / Indicators Indicators timeline interactions should add entry in timeline when clicking in an indicator flyout overview block
[job] [logs] Threat Intelligence Tests #4 / Indicators Indicators timeline interactions should add entry in timeline when clicking in an indicator flyout overview tab table row
[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Related integrations installed integrations: Amazon CloudFront, AWS CloudTrail, System, enabled integrations: Amazon CloudFront, Aws Cloudfront, System "before all" hook for "should display a badge with the installed integrations on the rule management page"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`advancedSettings`	50.5KB	50.5KB	+6.0B
`aiops`	753.6KB	753.6KB	+14.0B
`apm`	3.8MB	3.8MB	+52.0B
`canvas`	1.0MB	1.0MB	+8.0B
`cases`	364.0KB	364.0KB	+12.0B
`cloudDefend`	254.2KB	254.2KB	+4.0B
`cloudSecurityPosture`	149.4KB	149.4KB	+6.0B
`console`	417.9KB	417.9KB	+2.0B
`controls`	179.4KB	179.4KB	+2.0B
`crossClusterReplication`	168.2KB	168.2KB	+12.0B
`dashboard`	386.7KB	386.7KB	+2.0B
`data`	52.7KB	52.6KB	-39.0B
`dataViewFieldEditor`	156.1KB	156.1KB	+8.0B
`dataViewManagement`	118.6KB	118.6KB	+18.0B
`dataVisualizer`	366.1KB	366.1KB	+8.0B
`discover`	395.4KB	395.5KB	+28.0B
`enterpriseSearch`	2.2MB	2.2MB	+14.0B
`expressionError`	13.2KB	13.2KB	+2.0B
`expressionPartitionVis`	52.9KB	52.9KB	+2.0B
`expressionTagcloud`	7.7KB	7.7KB	+4.0B
`filesManagement`	86.0KB	86.0KB	+2.0B
`fileUpload`	853.4KB	853.4KB	+4.0B
`fleet`	939.1KB	939.2KB	+38.0B
`graph`	453.2KB	453.2KB	+4.0B
`grokdebugger`	59.1KB	59.1KB	+2.0B
`home`	153.9KB	153.9KB	+2.0B
`imageEmbeddable`	49.8KB	49.8KB	+2.0B
`indexLifecycleManagement`	157.8KB	157.8KB	+10.0B
`indexManagement`	525.4KB	525.5KB	+40.0B
`infra`	1.3MB	1.3MB	+46.0B
`ingestPipelines`	443.0KB	443.0KB	+20.0B
`inputControlVis`	49.9KB	49.9KB	+2.0B
`lens`	1.3MB	1.3MB	+20.0B
`licenseManagement`	65.2KB	65.2KB	+4.0B
`lists`	153.2KB	153.2KB	+4.0B
`maps`	2.7MB	2.7MB	+18.0B
`ml`	3.4MB	3.4MB	+46.0B
`monitoring`	458.2KB	458.2KB	+18.0B
`observability`	1.1MB	1.1MB	+10.0B
`osquery`	1.1MB	1.1MB	+2.0B
`painlessLab`	16.1KB	16.1KB	+2.0B
`presentationUtil`	129.0KB	129.0KB	+2.0B
`profiling`	262.9KB	262.9KB	+2.0B
`remoteClusters`	84.9KB	84.9KB	+10.0B
`reporting`	58.8KB	58.8KB	-5.0B
`rollup`	131.2KB	131.2KB	+6.0B
`savedObjectsManagement`	87.6KB	87.6KB	+10.0B
`searchprofiler`	159.0KB	159.0KB	+2.0B
`security`	556.9KB	556.9KB	+27.0B
`securitySolution`	15.8MB	15.8MB	+135.0B
`sessionView`	382.9KB	383.0KB	+4.0B
`snapshotRestore`	269.6KB	269.7KB	+24.0B
`spaces`	174.6KB	174.6KB	+8.0B
`stackAlerts`	80.3KB	80.3KB	+6.0B
`stackConnectors`	419.5KB	419.5KB	+12.0B
`synthetics`	1.4MB	1.4MB	+44.0B
`threatIntelligence`	52.3KB	52.3KB	+2.0B
`transform`	372.7KB	372.7KB	+20.0B
`triggersActionsUi`	1.4MB	1.4MB	+50.0B
`uiActionsEnhanced`	133.2KB	133.2KB	+6.0B
`unifiedFieldList`	50.6KB	50.7KB	+4.0B
`unifiedHistogram`	38.3KB	38.3KB	+2.0B
`unifiedSearch`	266.8KB	266.8KB	-56.0B
`upgradeAssistant`	152.2KB	152.3KB	+60.0B
`visDefaultEditor`	142.6KB	142.6KB	+2.0B
`visTypeTimeseries`	507.5KB	507.6KB	+10.0B
`visTypeVega`	1.7MB	1.7MB	+2.0B
`visualizations`	259.7KB	259.7KB	+12.0B
`watcher`	273.3KB	273.3KB	+8.0B
total			+870.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`charts`	45.8KB	45.8KB	+4.0B
`core`	350.8KB	350.8KB	+8.0B
`dataViewFieldEditor`	23.3KB	23.3KB	+2.0B
`embeddable`	75.3KB	75.3KB	+2.0B
`esUiShared`	152.4KB	152.4KB	+4.0B
`fleet`	125.6KB	125.6KB	+2.0B
`interactiveSetup`	58.6KB	58.6KB	+2.0B
`kbnUiSharedDeps-npmDll`	5.4MB	5.4MB	+1.2KB
`ml`	79.6KB	79.6KB	+2.0B
`osquery`	50.3KB	50.3KB	+2.0B
`reporting`	42.5KB	42.5KB	+2.0B
`security`	60.7KB	60.7KB	+2.0B
`share`	51.5KB	51.5KB	+2.0B
`triggersActionsUi`	83.6KB	83.6KB	+6.0B
total			+1.3KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	433	436	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	513	516	+3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

With EUI v76, `warning` icon type was introduced: #152506 However, the EUI upgrade was only applied on 8.8. The callout here that uses the warning icon was backported to 8.7, where the EUI version does not have the `warning` icon type. Thus 8.7 should still use the legacy `alert` icon type. This PR fixes that and will only be merged into 8.7.

Originally reported in #152234 (comment) With EUI v76, `warning` icon type was introduced: #152506 However, the EUI upgrade was only applied on 8.8. The callout here that uses the warning icon was a bug fix backported to 8.7 after the EUI upgrade. In 8.7 the EUI version does not have the `warning` icon type, causing a broken image to be rendered in this callout. This PR reverts the icon to the legacy `alert` type will only be merged into 8.7.

Upgraded EUI to v76.0.0

7a210af

JasonStoltz added EUI release_note:fix ci:cloud-deploy Create or update a Cloud deployment v8.8.0 labels Mar 1, 2023

JasonStoltz added 2 commits March 2, 2023 14:41

Updated snapshots

d2322f2

Patched to 76.0.1

a6d2dbf

JasonStoltz marked this pull request as ready for review March 6, 2023 13:14

JasonStoltz requested review from a team as code owners March 6, 2023 13:14

Merge branch 'main' into eui-v76.0.0

66da17e

jbudz approved these changes Mar 6, 2023

View reviewed changes

Fixed snapshot

8614cf5

JasonStoltz requested a review from a team as a code owner March 6, 2023 20:24

JasonStoltz and others added 6 commits March 6, 2023 15:26

Merge branch 'main' into eui-v76.0.0

0dd30b1

alert → warning, crossInACircleFilled → error

41d1ff5

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Convert more instances of crossInACircleFilled

fdbcb18

- Errors -> `error` - Delete actions -> `trash` - Clear actions -> `cross` or `minusInCircleFilled` (if used alongside `plusInCircleFilled`)

Convert instances of alert usages combined w/ error vars & danger c…

29c3495

…olor to use new `error` icon instead

Convert remaining instances of alert icon types to warning

f937d95

Update tests, mocks, and snapshots with alert->warning

7308657

cee-chen requested a review from a team as a code owner March 7, 2023 21:31

cee-chen requested a review from a team March 7, 2023 21:31

cee-chen requested review from a team as code owners March 7, 2023 21:31

daveyholler approved these changes Mar 8, 2023

View reviewed changes

cee-chen added 4 commits March 8, 2023 13:55

Merge remote-tracking branch 'upstream/main' into eui-v76.0.0

ae2ebad

[PR feedback] Fix server-side warning icon

1351cba

[PR feedback] Switch error icon to warning

9b2eb8f

Actually fix SSR warning icon

3e75f2b

- fix missing renames

Merge branch 'main' into eui-v76.0.0

48ca8eb

kc13greiner approved these changes Mar 9, 2023

View reviewed changes

justinkambic approved these changes Mar 9, 2023

View reviewed changes

kibanamachine and others added 3 commits March 9, 2023 12:25

Merge branch 'main' into eui-v76.0.0

ca4887c

Update to latest EUI v76.0.2 backport

15a2b70

Merge remote-tracking branch 'upstream/main' into eui-v76.0.0

7edfcf4

Merge branch 'main' into eui-v76.0.0

e62fc7c

cauemarcondes approved these changes Mar 10, 2023

View reviewed changes

nchaulet approved these changes Mar 10, 2023

View reviewed changes

michaelolo24 approved these changes Mar 10, 2023

View reviewed changes

drewdaemon approved these changes Mar 10, 2023

View reviewed changes

vadimkibana approved these changes Mar 13, 2023

View reviewed changes

Merge branch 'main' into eui-v76.0.0

fb004ab

Merge branch 'main' into eui-v76.0.0

c6e73d4

jbudz merged commit c339ca8 into elastic:main Mar 14, 2023

kibanamachine added the backport:skip This PR does not require backporting label Mar 14, 2023

jen-huang mentioned this pull request Mar 31, 2023

[Fleet] Fix warning icon not displaying on 8.7 #154119

Merged

Upgraded EUI to v76.0.0 #152506

Upgraded EUI to v76.0.0 #152506

Uh oh!

Conversation

JasonStoltz commented Mar 1, 2023 • edited by cee-chen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

76.0.2

76.0.1

76.0.0

Uh oh!

elasticmachine commented Mar 6, 2023

Uh oh!

azasypkin commented Mar 6, 2023

Uh oh!

cee-chen commented Mar 6, 2023

Uh oh!

daveyholler commented Mar 6, 2023

Uh oh!

JasonStoltz commented Mar 6, 2023

Uh oh!

daveyholler left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Mar 8, 2023

Uh oh!

kc13greiner left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Mar 9, 2023

Uh oh!

cee-chen commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

michaelolo24 left a comment

Choose a reason for hiding this comment

Uh oh!

drewdaemon left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Mar 14, 2023

Uh oh!

kibana-ci commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

JasonStoltz commented Mar 1, 2023 •

edited by cee-chen

Loading

`76.0.2`

`76.0.1`

`76.0.0`

cee-chen commented Mar 10, 2023 •

edited

Loading

kibana-ci commented Mar 14, 2023 •

edited

Loading