Rename getEditAlertFlyout to getEditRuleFlyout#153243
Merged
CoenWarmer merged 2 commits intoelastic:mainfrom Mar 20, 2023
Merged
Rename getEditAlertFlyout to getEditRuleFlyout#153243CoenWarmer merged 2 commits intoelastic:mainfrom
CoenWarmer merged 2 commits intoelastic:mainfrom
Conversation
botelastic
bot
added
the
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
CoenWarmer
added
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
mikecote
approved these changes
Mar 16, 2023
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
ResponseOps code changes LGTM 👍 thank you for the rename!
walterra
approved these changes
Mar 20, 2023
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
ML/Transform changes LGTM.
shahzad31
approved these changes
Mar 20, 2023
v1v
added a commit
to v1v/kibana
that referenced
this pull request
Mar 20, 2023
…loy-my-kibana-oblt * upstream/main: (727 commits) Upgrade caniuse-lite db (elastic#153318) [Security Solution] expanded flyout - right section - json tab implementation (elastic#152935) chore(slo): Make APM indicator's index required (elastic#153311) skip failing test suite (elastic#136688) [Security Solution] Fix security-solution storybook package codeowners (elastic#153307) [EUI] Add `scrollLock` workaround CSS to Kibana's `body` (elastic#153227) [Cloud Security] Show coming soon deployments of vulnerability management (elastic#153249) [Cloud Security] fixed onboarding link directs to cspm integration (elastic#153268) [Response Ops][Alerting] Reusable functions for FAAD resource installation (elastic#152849) remove geohash_grid aggregation support (elastic#152952) [Tech Debt] Reorder Rules page (elastic#152897) [Saved Object Finder] Add help text & left button (elastic#152742) [Transform] Replace SavedObjectsFinder component (elastic#153128) Make pipeline creation endpoint accept a full pipeline definition (elastic#153133) [Fleet] Displaying policy changes in Agent activity (elastic#153237) skip flaky suite (elastic#152852) [Security Solution][Endpoint] Add tests to cover RBAC entries in the Role Kibana Privileges flyout (elastic#153068) [Security Solution][Endpoint] Additional tests for Response Console History Log page (covers TestRail manual tests) (elastic#153042) [Monitoring] Display node roles in Nodes table (elastic#152127) Rename getEditAlertFlyout to getEditRuleFlyout (elastic#153243) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #156982
Summary
This PR renames the
getEditAlertFlyouttogetEditRuleFlyout, to make it more clear what component is returned.