[Monitoring] Display node roles in Nodes table#152127
Merged
miltonhultgren merged 9 commits intoelastic:mainfrom Mar 20, 2023
Merged
[Monitoring] Display node roles in Nodes table#152127miltonhultgren merged 9 commits intoelastic:mainfrom
miltonhultgren merged 9 commits intoelastic:mainfrom
Conversation
miltonhultgren
added
Team:Infra Monitoring UI - DEPRECATED
Contributor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Contributor
Author
|
@formgeist In the screenshot in the description, I randomly grabbed some roles out of the possible values just to see what it might look like, feedback welcome! (list of nodes is not sorted, and combination of roles are likely not valid, I'd still imagine the |
tonyghiani
reviewed
Feb 27, 2023
x-pack/plugins/monitoring/public/components/elasticsearch/nodes/nodes.js
Outdated
Show resolved
Hide resolved
tonyghiani
reviewed
Feb 27, 2023
x-pack/plugins/monitoring/public/application/pages/elasticsearch/nodes_page.tsx
Outdated
Show resolved
Hide resolved
tonyghiani
approved these changes
Feb 27, 2023
Contributor
tonyghiani
left a comment
tonyghiani
left a comment
There was a problem hiding this comment.
It is functionally working and LGTM, I just left a couple of suggestions (totally non-blocking), nice feature 👏
miltonhultgren
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
v1v
added a commit
to v1v/kibana
that referenced
this pull request
Mar 20, 2023
…loy-my-kibana-oblt * upstream/main: (727 commits) Upgrade caniuse-lite db (elastic#153318) [Security Solution] expanded flyout - right section - json tab implementation (elastic#152935) chore(slo): Make APM indicator's index required (elastic#153311) skip failing test suite (elastic#136688) [Security Solution] Fix security-solution storybook package codeowners (elastic#153307) [EUI] Add `scrollLock` workaround CSS to Kibana's `body` (elastic#153227) [Cloud Security] Show coming soon deployments of vulnerability management (elastic#153249) [Cloud Security] fixed onboarding link directs to cspm integration (elastic#153268) [Response Ops][Alerting] Reusable functions for FAAD resource installation (elastic#152849) remove geohash_grid aggregation support (elastic#152952) [Tech Debt] Reorder Rules page (elastic#152897) [Saved Object Finder] Add help text & left button (elastic#152742) [Transform] Replace SavedObjectsFinder component (elastic#153128) Make pipeline creation endpoint accept a full pipeline definition (elastic#153133) [Fleet] Displaying policy changes in Agent activity (elastic#153237) skip flaky suite (elastic#152852) [Security Solution][Endpoint] Add tests to cover RBAC entries in the Role Kibana Privileges flyout (elastic#153068) [Security Solution][Endpoint] Additional tests for Response Console History Log page (covers TestRail manual tests) (elastic#153042) [Monitoring] Display node roles in Nodes table (elastic#152127) Rename getEditAlertFlyout to getEditRuleFlyout (elastic#153243) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151818
Related PR: elastic/beats#34668