[maps] unskip Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/dashboard_maps_by_value·ts#152850
Merged
nreese merged 5 commits intoelastic:mainfrom Mar 9, 2023
Merged
Conversation
…l/apps/dashboard/group2/dashboard_maps_by_value·ts
2 tasks
nreese
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
nickpeihl
approved these changes
Mar 9, 2023
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm!
code review and tested kibana fonts fallback with EMS fonts url blocked
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…l/apps/dashboard/group2/dashboard_maps_by_value·ts (elastic#152850) Fixes elastic#152476 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995 elastic#152396 added an await to map loading that waits for EMS fonts HEAD request. This introduced test flakiness. This PR resolves the issue by re-working the solution from elastic#152476 to not block map loading for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts HEAD request fails after map has loaded. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152476
flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995
#152396 added an await to map loading that waits for EMS fonts HEAD request. This introduced test flakiness. This PR resolves the issue by re-working the solution from #152476 to not block map loading for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts HEAD request fails after map has loaded.