[maps] fix layers are not displayed in offline environment and map.includeElasticMapsService not set to false#152396
Merged
nreese merged 5 commits intoelastic:mainfrom Mar 1, 2023
Merged
Conversation
…cludeElasticMapsService not set to false
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
nreese
added
release_note:fix
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Mar 1, 2023
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! just one nit.
thanks for the fix! code review and tested by blocking access to tiles.elastic.co/*
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| `Unable to access fonts from Elastic Maps Service (EMS). Set kibana.yml 'map.includeElasticMapsService: false' to avoid unnecessary EMS requests.` | ||
| ); |
Contributor
There was a problem hiding this comment.
Nit. This warning will only be visible in the browser console of a client which might not be the best audience. Since we're suggesting changing kibana.yml, maybe we should instead log this warning in the kibana log where an administrator might see it?
Contributor
Author
There was a problem hiding this comment.
Do you know if its possible to write kibana logs from the client?
Contributor
There was a problem hiding this comment.
oh right. nevermind. also, after more consideration, I realize this is definitely more related to the client's environment as they might not have external internet access, but other clients accessing the kibana cluster may have access. so the warning would probably not be very useful for admins.
This was referenced Mar 7, 2023
nreese
added a commit
that referenced
this pull request
Mar 9, 2023
…l/apps/dashboard/group2/dashboard_maps_by_value·ts (#152850) Fixes #152476 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995 #152396 added an await to map loading that waits for EMS fonts HEAD request. This introduced test flakiness. This PR resolves the issue by re-working the solution from #152476 to not block map loading for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts HEAD request fails after map has loaded. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…cludeElasticMapsService not set to false (elastic#152396) Fixes elastic#152389 PR adds check to ensure client has access to EMS before using EMS fonts. If the client does not have access to EMS fonts then a warning is logged and map falls back to open sans fonts served from Kibana server.
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
…l/apps/dashboard/group2/dashboard_maps_by_value·ts (elastic#152850) Fixes elastic#152476 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1995 elastic#152396 added an await to map loading that waits for EMS fonts HEAD request. This introduced test flakiness. This PR resolves the issue by re-working the solution from elastic#152476 to not block map loading for EMS fonts HEAD request. Instead, glyphs URL is updated if EMS fonts HEAD request fails after map has loaded. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152389
PR adds check to ensure client has access to EMS before using EMS fonts. If the client does not have access to EMS fonts then a warning is logged and map falls back to open sans fonts served from Kibana server.