[Elasticsearch] Log queued requests#152571
Merged
afharo merged 3 commits intoelastic:mainfrom Mar 6, 2023
Merged
Conversation
08237b7 to
604ccb8
Compare
afharo
commented
Mar 2, 2023
Comment on lines
81
to
90
Member
Author
There was a problem hiding this comment.
I moved the calculation logic closer to the Agent Manager so that we didn't need to expose the logger publicly.
At the same time, it feels safer if we are not exposing the agents publicly for anyone else to tamper with.
46ef750 to
e690128
Compare
e690128 to
75e8b86
Compare
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @afharo |
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
Mar 6, 2023
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #152452.
It logs a warning when the HTTP Agent handling Elasticsearch connections has queued requests waiting for an available socket.
This will increase the observability of how the shared HTTP Agents are performing and will unblock the work in #151911.
Checklist
For maintainers
How to test
Setting
elasticsearch.maxSockets: 1inkibana.ymlshould make the log show whenever there's anything requesting information from ES (a user is logging in or a dashboard is refreshing).