[poc][serverless] Unified Navigation#152172
Closed
clintandrewhall wants to merge 76 commits intoelastic:mainfrom
Closed
[poc][serverless] Unified Navigation#152172clintandrewhall wants to merge 76 commits intoelastic:mainfrom
clintandrewhall wants to merge 76 commits intoelastic:mainfrom
Conversation
5588e5d to
5cdb373
Compare
00ba366 to
e0e35ca
Compare
815e429 to
69b62cc
Compare
69b62cc to
ec92b8a
Compare
e43e5db to
a1aa9cd
Compare
[PoC][Security Solution] Serverless navigation
…t/disable-plugins [Serverless] Disable Management team plugins
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
miscellaneous assets size
History
To update your PR or re-run it, just comment with: cc @tsullivan @rudolf @pgayvallet @lukeelmers @thomasneirynck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing in favor of #153274
This PR sources changes from my fork of Kibana, which doesn't allow PRs opened against it to run CI and other tasks. I'm closing this PR in favor of #153274, which consolidates the changes.
Thank you to all who contributed here!
cc: @TattdCodeMonkey @semd @yuliacech @tsullivan
Summary
This POC is an application of the principles I've outlined elsewhere, using "unified navigation" as a functional example, where:
corechanges are established as functional changes, rather than "serverless" changes;chromeStyle,setSolutionNavigationisSidebarEnabledserverlessplugin provides APIs related to Serverless functional implementations;setServerlessNavigationserverless-[project space]plugins usecore,serverlessand other plugins to create their Kibana configuration.By simply enabling the
serverlessandserverless-*plugin, we can create a project.Notes
serverlessplugin simply provides an alias tocoreto populate the navigation area. While anemic in this POC, it is assumed there would be much more business/functional logic here, and that we'd expectserverless-*plugins to avoid usingcoreAPIs directly, (beyond the obvious usages, e.g.basePath, etc)Testing
Run
yarn serverless-obltoryarn serverless-securitylocally.Next Steps
The immediate next step is to coalesce the different navigation requirements into a @elastic/appex-sharedux component downstream teams could consume to create a unified experience, (@tsullivan) Look to
serverless_*/public/plugin.tsxfor calls to theserverlessplugin to render navigation.We've had conversations with @elastic/security-solution and @elastic/observability-ui, and we can use this POC as a "jumping-off point" to iterate on navigation schemes. We can also continue to use this to validate the UX technical approach.