[PoC][Security Solution] Serverless navigation#30
Merged
clintandrewhall merged 27 commits intoclintandrewhall:serverless/poc/navigationfrom Mar 15, 2023
Merged
Conversation
…l/kibana into serverless/poc/navigation
Owner
|
This is awesome. @tsullivan, @sixstringcode, we should look at what was done here for elastic#152510. @semd I'm not sure if we'll merge this directly to the PoC, or if we'll include it as part of the navigation component package that @tsullivan is working on. Let's discuss on Monday. At the very least, we can use the package as a Thank you for this, it's incredibly important context for how we'll unify nav in projects. |
…om/semd/kibana into security_serverless_navigation_poc
|
This looks so polished, thanks for jumping on this so quick @semd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This POC is an implementation on top of the @clintandrewhall PoC, that integrates the current Security "grouped" navigation in the global chrome navigation for serverless.
SolutionGroupedNavigationmigrated to shared-ux package component asSideNavigation.navItems$on-start observable exposed.Limitations
mount, we can expose the store to be consumed from the serverless_security plugin, even if it may not exist when we are on a non-security page. However, this is non-critical since all pages add their specific urlState to the URL (using replace) when they load, so links can still be shared after navigation. We only lose urlState information when right-clicking and using "copy link address" in the navigation links directly.Testing
Run
yarn serverless-securitylocally.Screenshots