Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade Node.js to version 16 #149531

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Downgrade Node.js to version 16 #149531

merged 2 commits into from
Jan 26, 2023

Conversation

watson
Copy link
Contributor

@watson watson commented Jan 25, 2023 •
edited
Loading

Closes #149438

We'll upgrade again once a suitable solution to the issue has been found.

@watson watson self-assigned this Jan 25, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 25, 2023
@watson watson mentioned this pull request Jan 25, 2023
Closed
@jsanz jsanz mentioned this pull request Jan 25, 2023
Closed
@watson watson marked this pull request as ready for review January 25, 2023 17:32
@watson watson requested review from a team as code owners January 25, 2023 17:32
@watson watson requested a review from a team January 25, 2023 17:32
@watson watson requested review from a team as code owners January 25, 2023 17:32
pmuellr
pmuellr approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

TinaHeiligers
TinaHeiligers approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM. Thanks for jumping on this.

@watson watson mentioned this pull request Jan 26, 2023
Closed
@shahzad31
Copy link
Contributor

Merging main should resolve Synthetics @elastic/synthetics Tests failures !!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

sphilipse
sphilipse approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ent-search changes LGTM

@mistic mistic merged commit 6a0f7b9 into elastic:main Jan 26, 2023
@watson watson deleted the downgrade-node branch January 26, 2023 11:54
@jbudz jbudz mentioned this pull request Jan 26, 2023
Merged
jbudz added a commit that referenced this pull request Jan 26, 2023
@jbudz
Revert "[build] Fix canvas shareable runtime" (#149595)
c5400ce 
Reverts #149165

Node 18 was downgraded to Node 16, this flag is not supported -
#149531
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@kqualters-elastic
Downgrade Node.js to version 16 (elastic#149531)
da7f284 
Closes elastic#149438

We'll upgrade again once a suitable solution to the issue has been
found.
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@jbudz @kqualters-elastic
Revert "[build] Fix canvas shareable runtime" (elastic#149595)
2f05ab5 
Reverts elastic#149165

Node 18 was downgraded to Node 16, this flag is not supported -
elastic#149531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

@vadimkibana vadimkibana vadimkibana approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@watson watson

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kibana 8.7.0-snapshot with Node 18.x does not install on Ubuntu 18.04
10 participants
@watson @elasticmachine @shahzad31 @kibana-ci @pmuellr @TinaHeiligers @vadimkibana @sphilipse @mistic @kibanamachine