[build] Fix canvas shareable runtime #149165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
approved these changes
Jan 18, 2023
ThomThomson
approved these changes
Jan 18, 2023
💚 Build Succeeded
Metrics [docs]Canvas Sharable Runtime
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.7.0
backport:skip
wayneseymour
pushed a commit
to wayneseymour/kibana
that referenced
this pull request
Jan 19, 2023
The canvas shareable runtime build uses webpack 4, which needs the `--legacy-openssl-provider` flag after the recent Node 16 -> 18 upgrade. Context: the runtime build is disabled by default in pull requests because it's currently untested and adds ~3 minutes to build time. It is enabled in our nightly snapshots pipeline, which we've been using as a slower feedback loop for build issues. ## Testing ``` node x-pack/plugins/canvas/scripts/shareable_runtime.js ``` should exit 0
jbudz
added a commit
that referenced
this pull request
Jan 26, 2023
jbudz
added a commit
that referenced
this pull request
Jan 26, 2023
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
Reverts elastic#149165 Node 18 was downgraded to Node 16, this flag is not supported - elastic#149531
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canvas shareable runtime build uses webpack 4, which needs the
--legacy-openssl-providerflag after the recent Node 16 -> 18 upgrade.Context: the runtime build is disabled by default in pull requests because it's currently untested and adds ~3 minutes to build time. It is enabled in our nightly snapshots pipeline, which we've been using as a slower feedback loop for build issues.
Testing
should exit 0