[Security Solution ] expanded flyout - Redux store#149169
Closed
PhilippeOberti wants to merge 3 commits intomainfrom
Closed
[Security Solution ] expanded flyout - Redux store#149169PhilippeOberti wants to merge 3 commits intomainfrom
PhilippeOberti wants to merge 3 commits intomainfrom
Conversation
330bf66 to
101e3f9
Compare
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
101e3f9 to
6ec58b7
Compare
41b444c to
3e80a7a
Compare
3e80a7a to
a71864e
Compare
- feature flag - store setup (actions, reducers, selectors) - skeleton of the expanded flyout with left, right and preview panels
df5772f to
f7f8cc6
Compare
f7f8cc6 to
eb7ad45
Compare
eb7ad45 to
fc778e9
Compare
3 tasks
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
closing this PR in favor of this one which is similar but doesn't use Redux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first of many implementing a new expanded flyout.
Mocks can be found here.
This first part was based on some preliminary work done by @michaelolo24 and can be seen in this draft PR.
Here's what's included in this PR:
securityFlyoutEnabledfeature flag while we're working on the expanded flyout over multiple PRsCommits
TODO
How to test
xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']to thekibana.jsonfileScreen.Recording.2023-02-01.at.5.10.45.PM.mov
Notes/thoughts
What's next?