Skip to content

WIP#148827

Closed
michaelolo24 wants to merge 7 commits intoelastic:mainfrom
michaelolo24:security-flyout
Closed

WIP#148827
michaelolo24 wants to merge 7 commits intoelastic:mainfrom
michaelolo24:security-flyout

Conversation

@michaelolo24
Copy link
Copy Markdown
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jan 12, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / event details panel component Alerts it does NOT use the alerts alias when regular events happen to include a trailing '.alerts-security.alerts' in the index name
  • [job] [logs] Jest Tests #6 / event details panel component Alerts it uses the alias alerts index
  • [job] [logs] Jest Tests #6 / event details panel component Alerts it uses the alias alerts preview index
  • [job] [logs] Security Solution Tests #4 / url state sets KQL in host page and detail page and check if href match on breadcrumb, tabs and subTabs
  • [job] [logs] Security Solution Tests #4 / url state sets KQL in host page and detail page and check if href match on breadcrumb, tabs and subTabs

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3480 3515 +35

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.7MB 12.8MB +30.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 51.6KB 51.7KB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@michaelolo24
Copy link
Copy Markdown
Contributor Author

Closing as this work is being done in a separate group of smaller PR's!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants