Skip to content

[Controls] Revert input prop deletion from ControlGroupRenderer#146593

Closed
jennypavlova wants to merge 1 commit intoelastic:mainfrom
jennypavlova:145935-revert-input-prop-deletion
Closed

[Controls] Revert input prop deletion from ControlGroupRenderer#146593
jennypavlova wants to merge 1 commit intoelastic:mainfrom
jennypavlova:145935-revert-input-prop-deletion

Conversation

@jennypavlova
Copy link
Member

Summary

This PR reverts the deletion of the input prop from ControlGroupRenderer (added in #146189) because it was a breaking change for integration in the Host View page implemented in #145935

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Controls v8.7.0 labels Nov 29, 2022
@jennypavlova jennypavlova self-assigned this Nov 29, 2022
@jennypavlova jennypavlova requested a review from a team as a code owner November 29, 2022 17:06
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
controls 236 237 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
controls 34.5KB 34.7KB +216.0B
Unknown metric groups

API count

id before after diff
controls 245 246 +1

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Project:Controls release_note:skip Skip the PR/issue when compiling release notes v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants