Adds the VisEditor docs for 8.6#146471
Merged
KOTungseth merged 6 commits intoelastic:mainfrom Dec 8, 2022
Merged
Conversation
KOTungseth
added
Team:Docs
release_note:skip
KOTungseth
requested review from
Kuznietsov,
VladLasitsa,
dej611,
gchaps,
mbondyra and
stratoula
Contributor
|
Pinging @elastic/kibana-docs (Team:Docs) |
Contributor
|
Documentation preview: |
Contributor
Author
|
@elasticmachine merge upstream |
stratoula
reviewed
Dec 6, 2022
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Kaarina thank you a lot for working on this! I added some comments. I can't find the documentation for the adhoc dataviews though
| * Metric | ||
| * Vertical bar | ||
|
|
||
| To get started, click *Edit visualization in Lens* in the toolbar. |
Contributor
There was a problem hiding this comment.
It is not on the toolbar, it is on the navigation panel (where inspect and save are)
Contributor
Author
There was a problem hiding this comment.
Gail and I did a UI review with Graham and Michael, and we decided to call this the toolbar. I'm totally down to do a UI review refresh! Especially if the Solutions UIs are planning to adopt this component and functionality.
Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>
gchaps
approved these changes
Dec 6, 2022
Contributor
gchaps
left a comment
gchaps
left a comment
There was a problem hiding this comment.
LGTM with a few comments.
| @@ -240,7 +250,7 @@ image::images/lens_referenceLine_7.16.png[Lens drag and drop focus state] | |||
| [[filter-the-data]] | |||
| ==== Apply filters | |||
Contributor
There was a problem hiding this comment.
Something to think about for another PR. Should we move the filter information to a general section about filtering in the concepts section?
Contributor
Author
There was a problem hiding this comment.
The filter functionality here is specific to Lens. If other Solutions/apps/etc pick up the Lens filter components, then yes!
stratoula
approved these changes
Dec 8, 2022
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM! Thanx Kaarina ❤️
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2022
## Summary Adds the 8.6 for the following: - elastic#140878, elastic#143946 and elastic#142187 [Doc preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens) - elastic#142936, elastic#142561, elastic#143820, and elastic#142838 [Doc preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens) - elastic#138732 [Doc preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields) - elastic#141626 and elastic#141615 [Doc preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com> (cherry picked from commit f918a37)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [Adds the VisEditor docs for 8.6 (#146471)](#146471) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kaarina Tungseth","email":"kaarina.tungseth@elastic.co"},"sourceCommit":{"committedDate":"2022-12-08T20:18:03Z","message":"Adds the VisEditor docs for 8.6 (#146471)\n\n## Summary\r\n\r\nAdds the 8.6 for the following:\r\n\r\n- #140878, #143946 and #142187\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)\r\n\r\n- #142936, #142561, #143820, and #142838\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)\r\n\r\n- #138732\r\n \r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)\r\n\r\n- #141626 and #141615\r\n \r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>","sha":"f918a3745be3badff9cf05950db61d7f47877961","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v8.6.0","v8.7.0"],"number":146471,"url":"https://github.com/elastic/kibana/pull/146471","mergeCommit":{"message":"Adds the VisEditor docs for 8.6 (#146471)\n\n## Summary\r\n\r\nAdds the 8.6 for the following:\r\n\r\n- #140878, #143946 and #142187\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)\r\n\r\n- #142936, #142561, #143820, and #142838\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)\r\n\r\n- #138732\r\n \r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)\r\n\r\n- #141626 and #141615\r\n \r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>","sha":"f918a3745be3badff9cf05950db61d7f47877961"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146471","number":146471,"mergeCommit":{"message":"Adds the VisEditor docs for 8.6 (#146471)\n\n## Summary\r\n\r\nAdds the 8.6 for the following:\r\n\r\n- #140878, #143946 and #142187\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)\r\n\r\n- #142936, #142561, #143820, and #142838\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)\r\n\r\n- #138732\r\n \r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)\r\n\r\n- #141626 and #141615\r\n \r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>","sha":"f918a3745be3badff9cf05950db61d7f47877961"}}]}] BACKPORT--> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the 8.6 for the following:
[TSVB][Lens] Navigate to Lens TSVB Metric #140878, [Lens][TSVB] Navigate to Lens TSVB Table. #143946 and [Lens][TSVB] Navigate from TSVB Gauge to Lens Metric #142187
Doc preview
[Lens][Agg based XY] Convert to Lens Agg based XY. #142936, [Lens][Agg based metric] Convert to Lens Metric. #142561, [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. #143820, and [Lens][Agg based Gauge & Goal] Convert to Lens Agg based Gauge and Goal. #142838
Doc preview
[Lens] Enables ad-hoc dataviews #138732
Doc preview
[Lens] drag field to annotations to the config panel #141626 and [Lens] Add control for global filters to the annotation layer menu #141615
Doc preview