Skip to content

[Lens] drag field to annotations to the config panel #141626

Merged
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:lens/annotations_drag_drop
Sep 30, 2022
Merged

[Lens] drag field to annotations to the config panel #141626
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:lens/annotations_drag_drop

Conversation

@mbondyra
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra commented Sep 23, 2022 •
edited
Loading

Summary

Fixes #141033

Allows the field to be dropped to annotations layer.

  1. When dropping to the empty dimension, creates new annotation.
  2. When dropping to existing diemnsion, keeps the styles of the old one and adds the field:* query properties.
    ! Does not allow to drop a field to annotation layer with different data view.
Sep-28-2022.07-51-14.mp4

Some technical changes:

  • DragDropOperation and DraggedField and some helpers are now available both for datasource and visualization,
  • some props for DraggableDimensionButton got merged out into objects that describe better what they serve for (for example, instead of passing layerId, columnId and groupId I pass target with these three inside.
  • I consolidated datasource getCurrentIndexPattern and getUsedDataView into one method,
  • instead of having a generic getDropProps method for the layers without datasource (that was anyway used only for annotation case), I moved the method to be possibly implemented by visualization.

@mbondyra mbondyra added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting v8.6.0 labels Sep 23, 2022
@mbondyra mbondyra force-pushed the lens/annotations_drag_drop branch from e1d6c3e to eb63938 Compare September 27, 2022 16:33
mbondyra
mbondyra commented Sep 27, 2022
View reviewed changes
@mbondyra mbondyra force-pushed the lens/annotations_drag_drop branch 3 times, most recently from 4194dae to 61d7234 Compare September 29, 2022 08:21
@mbondyra mbondyra marked this pull request as ready for review September 29, 2022 08:25
@mbondyra mbondyra requested a review from a team as a code owner September 29, 2022 08:25
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 29, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra mbondyra force-pushed the lens/annotations_drag_drop branch from 76c5a28 to 1c5758c Compare September 29, 2022 08:37
@mbondyra mbondyra force-pushed the lens/annotations_drag_drop branch from 1c5758c to c126f9d Compare September 29, 2022 09:40
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 29, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 560 565 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +2.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lens 42 43 +1
Unknown metric groups

API count

id before after diff
lens 649 654 +5

History

  • 💚 Build #76783 succeeded 1c5758c457a399d113ff03949296de42d607ec20
  • 💚 Build #76313 succeeded 7230ca55b84caf6bff5f823c6df7a183e24528a2
  • 💔 Build #76307 failed 6aa9f7350df1dd22aaed4e8df502af37119a5c68
  • 💔 Build #76155 failed eb63938c3af8d7a9ac2c23d79d3784a5576dd6d9
  • 💚 Build #75253 succeeded e1d6c3e11df4770407d9d7f75e1d772f74a8e0a6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, LGTM

@mbondyra mbondyra merged commit 3bb04ab into elastic:main Sep 30, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 2, 2022
@mbondyra @WafaaNasr
[Lens] drag field to annotations to the config panel (elastic#141626)
cc3e0f5 
* getCurrentIndexPattern -> getUsedDataView

* implement dnd for field
@KOTungseth KOTungseth mentioned this pull request Nov 28, 2022
Merged
KOTungseth added a commit that referenced this pull request Dec 8, 2022
@KOTungseth @kibanamachine @stratoula
Adds the VisEditor docs for 8.6 (#146471)
f918a37 
## Summary

Adds the 8.6 for the following:

- #140878, #143946 and #142187

[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)

- #142936, #142561, #143820, and #142838

[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)

- #138732
  
[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)

- #141626 and #141615
  
[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2022
@KOTungseth @kibanamachine @stratoula
Adds the VisEditor docs for 8.6 (elastic#146471)
4949db1 
## Summary

Adds the 8.6 for the following:

- elastic#140878, elastic#143946 and elastic#142187

[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)

- elastic#142936, elastic#142561, elastic#143820, and elastic#142838

[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)

- elastic#138732

[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)

- elastic#141626 and elastic#141615

[Doc
preview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>
(cherry picked from commit f918a37)
kibanamachine added a commit that referenced this pull request Dec 8, 2022
@kibanamachine @KOTungseth
[8.6] Adds the VisEditor docs for 8.6 (#146471) (#147289)
d6e4afa 
# Backport

This will backport the following commits from `main` to `8.6`:
- [Adds the VisEditor docs for 8.6
(#146471)](#146471)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kaarina
Tungseth","email":"kaarina.tungseth@elastic.co"},"sourceCommit":{"committedDate":"2022-12-08T20:18:03Z","message":"Adds
the VisEditor docs for 8.6 (#146471)\n\n## Summary\r\n\r\nAdds the 8.6
for the following:\r\n\r\n- #140878, #143946 and
#142187\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)\r\n\r\n-
#142936, #142561, #143820, and
#142838\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)\r\n\r\n-
#138732\r\n
\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)\r\n\r\n-
#141626 and #141615\r\n
\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Stratoula Kalafateli
<stratoula1@gmail.com>","sha":"f918a3745be3badff9cf05950db61d7f47877961","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v8.6.0","v8.7.0"],"number":146471,"url":"https://github.com/elastic/kibana/pull/146471","mergeCommit":{"message":"Adds
the VisEditor docs for 8.6 (#146471)\n\n## Summary\r\n\r\nAdds the 8.6
for the following:\r\n\r\n- #140878, #143946 and
#142187\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)\r\n\r\n-
#142936, #142561, #143820, and
#142838\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)\r\n\r\n-
#138732\r\n
\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)\r\n\r\n-
#141626 and #141615\r\n
\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Stratoula Kalafateli
<stratoula1@gmail.com>","sha":"f918a3745be3badff9cf05950db61d7f47877961"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146471","number":146471,"mergeCommit":{"message":"Adds
the VisEditor docs for 8.6 (#146471)\n\n## Summary\r\n\r\nAdds the 8.6
for the following:\r\n\r\n- #140878, #143946 and
#142187\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/tsvb.html#edit-visualizations-in-lens)\r\n\r\n-
#142936, #142561, #143820, and
#142838\r\n\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#edit-agg-based-visualizations-in-lens)\r\n\r\n-
#138732\r\n
\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#change-the-fields)\r\n\r\n-
#141626 and #141615\r\n
\r\n[Doc\r\npreview](https://kibana_146471.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Stratoula Kalafateli
<stratoula1@gmail.com>","sha":"f918a3745be3badff9cf05950db61d7f47877961"}}]}]
BACKPORT-->

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] [Annotations] Add ability to drag and drop a field to annotation layer

4 participants

@mbondyra @elasticmachine @kibana-ci @flash1293