[8.6] [PresentationUtil] Fix Canvas expression autocomplete (#146425)#146465
Merged
kibanamachine merged 1 commit intoelastic:8.6from Nov 28, 2022
Merged
[8.6] [PresentationUtil] Fix Canvas expression autocomplete (#146425)#146465kibanamachine merged 1 commit intoelastic:8.6from
kibanamachine merged 1 commit intoelastic:8.6from
Conversation
Fixes elastic#146243 ## Summary Fixes Canvas expression autocomplete elastic#143739 upgraded the monaco-editor dependency which uses a callback to the `onLanguage` method to initialize the expressions. The PR moved the `monaco.languages.register` command inside this callback and which was never triggered. Moving the `monaco.languages.register` command outside the callback appears to fix the issue. (cherry picked from commit 19413b7)
kibanamachine
force-pushed
the
backport/8.6/pr-146425
branch
from
d38570e to
356aef6
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @nickpeihl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation