[PresentationUtil] Fix Canvas expression autocomplete#146425
Merged
nickpeihl merged 1 commit intoelastic:mainfrom Nov 28, 2022
Merged
[PresentationUtil] Fix Canvas expression autocomplete#146425nickpeihl merged 1 commit intoelastic:mainfrom
nickpeihl merged 1 commit intoelastic:mainfrom
Conversation
nickpeihl
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
|
@nickpeihl is it possible to add a test too? or would you like to us to own it? Thank you very much. |
Contributor
Author
Maybe. But I'd like to explore that in a different PR due to the urgency of this fix. |
Contributor
|
I created a tracking issue here - #146427 You can also assign it to me. Will get to it after release QA is in a good place. Thanks! |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
cqliu1
approved these changes
Nov 28, 2022
Contributor
cqliu1
left a comment
cqliu1
left a comment
There was a problem hiding this comment.
LGTM 👍 Tested it out locally, and autocomplete is back to normal.
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2022
Fixes elastic#146243 ## Summary Fixes Canvas expression autocomplete elastic#143739 upgraded the monaco-editor dependency which uses a callback to the `onLanguage` method to initialize the expressions. The PR moved the `monaco.languages.register` command inside this callback and which was never triggered. Moving the `monaco.languages.register` command outside the callback appears to fix the issue. (cherry picked from commit 19413b7)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2022
…#146465) # Backport This will backport the following commits from `main` to `8.6`: - [[PresentationUtil] Fix Canvas expression autocomplete (#146425)](#146425) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2022-11-28T19:30:37Z","message":"[PresentationUtil] Fix Canvas expression autocomplete (#146425)\n\nFixes #146243 \r\n\r\n## Summary\r\n\r\nFixes Canvas expression autocomplete\r\n\r\nhttps://github.com//pull/143739 upgraded the monaco-editor\r\ndependency which uses a callback to the `onLanguage` method to\r\ninitialize the expressions. The PR moved the `monaco.languages.register`\r\ncommand inside this callback and which was never triggered.\r\n\r\nMoving the `monaco.languages.register` command outside the callback\r\nappears to fix the issue.","sha":"19413b7daae983b95dbb9f5c7b39cb8f3578ebfa","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:prev-minor","v8.6.0","v8.7.0"],"number":146425,"url":"https://github.com/elastic/kibana/pull/146425","mergeCommit":{"message":"[PresentationUtil] Fix Canvas expression autocomplete (#146425)\n\nFixes #146243 \r\n\r\n## Summary\r\n\r\nFixes Canvas expression autocomplete\r\n\r\nhttps://github.com//pull/143739 upgraded the monaco-editor\r\ndependency which uses a callback to the `onLanguage` method to\r\ninitialize the expressions. The PR moved the `monaco.languages.register`\r\ncommand inside this callback and which was never triggered.\r\n\r\nMoving the `monaco.languages.register` command outside the callback\r\nappears to fix the issue.","sha":"19413b7daae983b95dbb9f5c7b39cb8f3578ebfa"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146425","number":146425,"mergeCommit":{"message":"[PresentationUtil] Fix Canvas expression autocomplete (#146425)\n\nFixes #146243 \r\n\r\n## Summary\r\n\r\nFixes Canvas expression autocomplete\r\n\r\nhttps://github.com//pull/143739 upgraded the monaco-editor\r\ndependency which uses a callback to the `onLanguage` method to\r\ninitialize the expressions. The PR moved the `monaco.languages.register`\r\ncommand inside this callback and which was never triggered.\r\n\r\nMoving the `monaco.languages.register` command outside the callback\r\nappears to fix the issue.","sha":"19413b7daae983b95dbb9f5c7b39cb8f3578ebfa"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146243
Summary
Fixes Canvas expression autocomplete
#143739 upgraded the monaco-editor dependency which uses a callback to the
onLanguagemethod to initialize the expressions. The PR moved themonaco.languages.registercommand inside this callback and which was never triggered.Moving the
monaco.languages.registercommand outside the callback appears to fix the issue.