Skip to content

[Cloud Posture] Adding cluster name to cluster card #144667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofiriro3 merged 2 commits into from
Nov 7, 2022
Merged

[Cloud Posture] Adding cluster name to cluster card #144667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8106a28
Adding cluster name to cluster card
ofiriro3 Nov 6, 2022
8ff3d18
Fixing test
ofiriro3 Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions x-pack/plugins/cloud_security_posture/common/schemas/csp_finding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ import type { CspRuleMetadata } from './csp_rule_metadata';
export interface CspFinding {
'@timestamp': string;
cluster_id: string;
cluster?: {
name?: string;
orchestrator?: {
cluster?: {
name?: string;
};
};
result: CspFindingResult;
resource: CspFindingResource;
Expand Down
6 changes: 5 additions & 1 deletion ...ck/plugins/cloud_security_posture/server/routes/compliance_dashboard/get_clusters.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ const mockClusterBuckets: ClusterBucket[] = [
_id: '123',
_index: '123',
_source: {
cluster: { name: 'cluster_name' },
orchestrator: {
cluster: {
name: 'cluster_name',
},
},
rule: { benchmark: { name: 'CIS Kubernetes', id: 'cis_k8s' } },
'@timestamp': '123',
},
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cloud_security_posture/server/routes/compliance_dashboard/get_clusters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export const getClustersFromAggs = (clusters: ClusterBucket[]): ClusterWithoutTr

const meta = {
clusterId: cluster.key,
clusterName: latestFindingHit._source.cluster?.name,
clusterName: latestFindingHit._source.orchestrator?.cluster?.name,
benchmarkName: latestFindingHit._source.rule.benchmark.name,
benchmarkId: latestFindingHit._source.rule.benchmark.id,
lastUpdate: latestFindingHit._source['@timestamp'],
Expand Down