Skip to content

[Cloud Posture] Adding cluster name to cluster card#144667

Merged
ofiriro3 merged 2 commits into
elastic:mainfrom
ofiriro3:add_cluster_name_to_cluster_card
Nov 7, 2022
Merged

[Cloud Posture] Adding cluster name to cluster card#144667
ofiriro3 merged 2 commits into
elastic:mainfrom
ofiriro3:add_cluster_name_to_cluster_card

Conversation

@ofiriro3
Copy link
Copy Markdown
Contributor

@ofiriro3 ofiriro3 commented Nov 6, 2022

Summary

This PR completes the task of showing the real cluster name in the UI.

In-Depth

As part of elastic/cloudbeat#391, we extracted the Kubernetes cluster name when collecting findings. Now we just wish to present it in the cluster-card in our dashboard screen.

image

@ofiriro3 ofiriro3 marked this pull request as ready for review November 6, 2022 16:38
@ofiriro3 ofiriro3 requested a review from a team as a code owner November 6, 2022 16:38
@ofiriro3 ofiriro3 linked an issue Nov 6, 2022 that may be closed by this pull request
12 tasks
@ofiriro3 ofiriro3 added the Team:Cloud Security Cloud Security team related label Nov 6, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

@ofiriro3 ofiriro3 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Nov 6, 2022
@ofiriro3 ofiriro3 changed the title Adding cluster name to cluster card [Cloud Posture] Adding cluster name to cluster card Nov 6, 2022
@ofiriro3 ofiriro3 assigned orouz and unassigned orouz and JordanSh Nov 6, 2022
@ofiriro3 ofiriro3 requested a review from JordanSh November 7, 2022 07:42
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ofiriro3 ofiriro3 merged commit f16c7d7 into elastic:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cluster name to findings - using existing impl. in libbeat

7 participants