Skip to content

Unskip Spaces A11y Tests #144156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuff-links merged 1 commit into from
Oct 28, 2022
Merged

Unskip Spaces A11y Tests #144156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 25 additions & 23 deletions x-pack/test/accessibility/apps/spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const toasts = getService('toasts');
const kibanaServer = getService('kibanaServer');

// FLAKY: https://github.com/elastic/kibana/issues/137136
describe.skip('Kibana Spaces Accessibility', () => {
describe('Kibana Spaces Accessibility', () => {
before(async () => {
await kibanaServer.savedObjects.cleanStandardList();
await PageObjects.common.navigateToApp('home');
Expand Down Expand Up @@ -86,29 +85,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

// creating space b and making it the current space so space selector page gets displayed when space b gets deleted
// FLAKY: https://github.com/elastic/kibana/issues/135341
it.skip('a11y test for delete space button', async () => {
await PageObjects.spaceSelector.clickCreateSpace();
await PageObjects.spaceSelector.clickEnterSpaceName();
await PageObjects.spaceSelector.addSpaceName('space_b');
await PageObjects.spaceSelector.clickSaveSpaceCreation();
await PageObjects.common.navigateToApp('home');
await PageObjects.spaceSelector.openSpacesNav();
await PageObjects.spaceSelector.clickSpaceAvatar('space_b');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.spaceSelector.openSpacesNav();
await PageObjects.spaceSelector.clickManageSpaces();
await PageObjects.spaceSelector.clickOnDeleteSpaceButton('space_b');
await a11y.testAppSnapshot();
});

// test starts with deleting space b so we can get the space selection page instead of logging out in the test
it('a11y test for space selection page', async () => {
await PageObjects.spaceSelector.confirmDeletingSpace();
await retry.try(async () => {
// Skipped due to an a11y violation
// https://github.com/elastic/kibana/issues/144155
describe.skip('Create Space B and Verify', async () => {
it('a11y test for delete space button', async () => {
await PageObjects.spaceSelector.clickCreateSpace();
await PageObjects.spaceSelector.clickEnterSpaceName();
await PageObjects.spaceSelector.addSpaceName('space_b');
await PageObjects.spaceSelector.clickSaveSpaceCreation();
await PageObjects.common.navigateToApp('home');
await PageObjects.spaceSelector.openSpacesNav();
await PageObjects.spaceSelector.clickSpaceAvatar('space_b');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.spaceSelector.openSpacesNav();
await PageObjects.spaceSelector.clickManageSpaces();
await PageObjects.spaceSelector.clickOnDeleteSpaceButton('space_b');
await a11y.testAppSnapshot();
});
await PageObjects.spaceSelector.clickSpaceCard('default');

// test starts with deleting space b so we can get the space selection page instead of logging out in the test
it('a11y test for space selection page', async () => {
await PageObjects.spaceSelector.confirmDeletingSpace();
await retry.try(async () => {
await a11y.testAppSnapshot();
});
await PageObjects.spaceSelector.clickSpaceCard('default');
});
});
});
}