Skip to content

Unskip Spaces A11y Tests#144156

Merged
cuff-links merged 1 commit into
elastic:mainfrom
cuff-links:Unskip_A11y_Tests_Spaces_137136
Oct 28, 2022
Merged

Unskip Spaces A11y Tests#144156
cuff-links merged 1 commit into
elastic:mainfrom
cuff-links:Unskip_A11y_Tests_Spaces_137136

Conversation

@cuff-links
Copy link
Copy Markdown
Contributor

@cuff-links cuff-links commented Oct 28, 2022

Closes #137136

Added a describe block for the tests that involve space b. There is a…
fd1727b 
…n accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped.
@cuff-links cuff-links added Project:Accessibility Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// test_xpack_functional release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing auto-backport Deprecated - use backport:version if exact versions are needed v8.6.0 v8.5.1 labels Oct 28, 2022
@cuff-links cuff-links changed the title Added a describe block for the tests that involve space b. There is a… Unskip Spaces A11y Tests Oct 28, 2022
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 28, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links cuff-links marked this pull request as ready for review October 28, 2022 12:59
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 28, 2022

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 28, 2022

Pinging @elastic/kibana-security (Team:Security)

LeeDr
LeeDr approved these changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review only

@cuff-links cuff-links merged commit dc5fd06 into elastic:main Oct 28, 2022
kibanamachine pushed a commit that referenced this pull request Oct 28, 2022
Added a describe block for the tests that involve space b. There is a…
007d29e 
…n accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped. (#144156)

(cherry picked from commit dc5fd06)
@kibanamachine kibanamachine mentioned this pull request Oct 28, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 28, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Oct 28, 2022
@kibanamachine
Added a describe block for the tests that involve space b. There is a…
8eb3aae 
…n accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped. (#144156) (#144192)

(cherry picked from commit dc5fd06)

Co-authored-by: John Dorlus <jsdorlus@elastic.co>
@mistic mistic removed the v8.5.0 label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhavyarm bhavyarm Awaiting requested review from bhavyarm

@rashmivkulkarni rashmivkulkarni Awaiting requested review from rashmivkulkarni

1 more reviewer

@LeeDr LeeDr LeeDr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// test_xpack_functional v8.5.1 v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing test: X-Pack Accessibility Tests.x-pack/test/accessibility/apps/spaces·ts - Kibana Spaces Accessibility a11y test for space selection page

6 participants

@cuff-links @kibana-ci @elasticmachine @kibanamachine @LeeDr @mistic