[Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy#144105
Merged
nchaulet merged 5 commits intoelastic:mainfrom Oct 28, 2022
Merged
Conversation
…from policies page
nchaulet
added
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Member
Author
|
@elasticmachine merge upstream |
hop-dev
approved these changes
Oct 28, 2022
Contributor
hop-dev
left a comment
hop-dev
left a comment
There was a problem hiding this comment.
Looks good to me, it's definitely an improvement 👍
| <EuiText> | ||
| <FormattedMessage | ||
| id="xpack.fleet.agentEnrollment.instructionstFleetServer" | ||
| defaultMessage="A Fleet Server is required before you can enroll agents with Fleet. Follow the instructions below to set up a Fleet Server. For more information, see the {userGuideLink}" |
Contributor
There was a problem hiding this comment.
The user might have a fleet server already set up, does this make it sound like they haven't and they need to add one to add an agent? We might want to get DeDe to review this
Member
Author
There was a problem hiding this comment.
I used the same copy that we use in the Add Fleet Server here, it probably had some unnecessary complexity (in my opinion) to add a specific copy if there is already a Fleet Server.
nchaulet
commented
Oct 28, 2022
...ck/plugins/fleet/public/applications/fleet/sections/agent_policy/components/actions_menu.tsx
Outdated
Show resolved
Hide resolved
…policy/components/actions_menu.tsx
Member
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @nchaulet |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 31, 2022
* main: (41 commits) [api-docs] Daily api_docs build (elastic#144212) Add readonly view to role management (elastic#143893) [api-docs] Daily api_docs build (elastic#144208) [APM] Adds button group to navigate to "All services" (elastic#142911) Update react-query to ^4.12.0 (main) (elastic#139986) [APM] Support specific fields when creating service groups (elastic#142201) (elastic#143881) [api-docs] Daily api_docs build (elastic#144203) [ts] add stub index.d.ts in @kbn/ui-shared-deps-npm [Synthetics] Fix failing Synthetics Integration test (elastic#144175) chore(NA): remove @types/pkg link creation when generating a new package (elastic#144200) [Osquery] Update schema to v5.5.1 (elastic#144090) [ci] remove github-checks-reporter (elastic#144193) [8.6][ML Inference] Verify pipeline usage before deletion (elastic#144053) [ts] ts refs cache was removed, remove capture task Added Rollups CCS Test (elastic#144074) [auto] migrate existing plugin/package configs [ts] stop building @types packages in bootstrap skip failing test suite (elastic#142762) skip failing test suite (elastic#144186) [Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy (elastic#144105) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #143519
@hop-dev @kpollich I am curious to get your thoughts on this as a potential solution to #143519
The behavior seen in #143519 was not totally incorrect as the Add agent Flyout allow to add a Fleet server so that PR make some changes to the add agent Flyout to use
Add Fleet Serverand update the copy when trying to add a Fleet server.UI Changes