[console] Revert removal of inferring request method #14032
Conversation
jbudz
added
Feature:Console
| var wrappedDfd = $.Deferred(); | ||
|
|
||
| console.log("Calling " + path); | ||
| var isGETRequest = /get/i.test(method) |
There was a problem hiding this comment.
Can we ensure the entire string is get and camelcase the variable name?
var isGetRequest = /^get$/i.test(method)
|
Should this go back to 6.0? |
|
I'm going to revert the last commit to get the master and 6.1 changes out of the way. And then I'll do the get request changes back to 5.6 in a new PR |
This reverts commit c749f8d.
|
What's the reason for reverting the case insensitivity? |
|
Only to make the backport to 6.0 and 5.6 clean - the PR this is reverting only went to 6.1 and 7.0. I'll open a followup after. |
| var wrappedDfd = $.Deferred(); | ||
|
|
||
| console.log("Calling " + path); | ||
| if (data && method == "GET") { |
There was a problem hiding this comment.
this needs to be case insensitive, quite often folks do get /something and then the body is ignored.
Mpdreamz
dismissed
their stale review
Just spotted c749f8d#r139834769, would love to see this go in 6.0 and 5.6 though,
|
Yes, planning on taking it back to 5.6. |
|
Ok, let's get this in and I have created a follow-up issue: #14280 |
3 participants
This reverts #13694 and reopens #13687. Ideally we could let this sit, but large chunks of our documentation make use of GET requests with bodies. In these cases the body would be ignored.
/cc @chrisronline