[console] Don't infer request method #13694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
Feature:Console
Member
Author
|
jenkins, test it |
jbudz
added a commit
that referenced
this pull request
Aug 25, 2017
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Sep 18, 2017
This reverts commit 38b13c7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently console will automatically change the request method from get to post if there's a body. It can cause unexpected behavior in certain cases and possibly lead to accidental document overwrites. The check is also case sensitive for "GET" and will behave differently if the method is "get".
To test,
should have the request method get appended as a query parameter (instead of post)
Closes #13687
Closes #10721