Skip to content

[inspector] remove root-level redirect to common#136999

Merged
spalger merged 6 commits intoelastic:mainfrom
spalger:fix/inspector/no-root-plugin-imports
Jul 25, 2022
Merged

[inspector] remove root-level redirect to common#136999
spalger merged 6 commits intoelastic:mainfrom
spalger:fix/inspector/no-root-plugin-imports

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Jul 22, 2022 •
edited by kibanamachine
Loading

In the inspector plugin there is an index.ts file outside of the server, public, and common directories that just re-exports the common exports. In the package system this will need to be removed and the common package will need to be imported directly. Additionally, we're working to get a step closer to that state in #136911 and these changes were extracted from there so that we are importing the exact plugin-section we want.

To accomplish this we used the @kbn/eslint/module_migration rule to remap all imports for @kbn/inspector-plugin (exactly) with @kbn/inspector-plugin/common and removed the old index.ts file.

@spalger spalger force-pushed the fix/inspector/no-root-plugin-imports branch from 0827e66 to b8866cc Compare July 22, 2022 21:04
@spalger spalger force-pushed the fix/inspector/no-root-plugin-imports branch from b8866cc to 67f22c0 Compare July 22, 2022 22:01
@spalger spalger added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Jul 22, 2022
@spalger spalger marked this pull request as ready for review July 22, 2022 22:01
@spalger spalger requested review from a team as code owners July 22, 2022 22:01
@spalger spalger requested a review from a team July 22, 2022 22:01
@spalger spalger requested review from a team as code owners July 22, 2022 22:01
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 22, 2022

Pinging @elastic/kibana-operations (Team:Operations)

@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 22, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 22, 2022

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 22, 2022

Pinging @elastic/uptime (Team:uptime)

kertal
kertal approved these changes Jul 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataDiscovery code changes LGTM, just imports were changed

stratoula
stratoula approved these changes Jul 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis Editors changes LGTM, 2 imports changed, code review only

Dosant
Dosant approved these changes Jul 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

gbamparop
gbamparop approved these changes Jul 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@gbamparop gbamparop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM!

ThomThomson
ThomThomson approved these changes Jul 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team import changes LGTM!

@spalger spalger enabled auto-merge (squash) July 25, 2022 15:12
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 25, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented Jul 25, 2022

@dominiqueclarke from @elastic/uptime confirmed on slack that these synthetic tests are not broken by this PR so I'm going to go ahead and merge since we've got a mixture of very flaky tests here.

@spalger spalger disabled auto-merge July 25, 2022 16:33
@spalger spalger merged commit 0596007 into elastic:main Jul 25, 2022
@spalger spalger deleted the fix/inspector/no-root-plugin-imports branch July 25, 2022 16:33
@kibanamachine

This comment was marked as outdated.

Sign in to view
@spalger spalger mentioned this pull request Jul 25, 2022
Merged
@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented Jul 25, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

spalger pushed a commit to spalger/kibana that referenced this pull request Jul 25, 2022
[inspector/expressions] remove root-level redirect to common (elastic…
55df917 
…#136999) (elastic#136997)

(cherry picked from commit 0596007)
spalger pushed a commit that referenced this pull request Jul 25, 2022
@kibanamachine
[inspector/expressions] remove root-level redirect to common (#136999) (
e2aa2fe 
#136997) (#137103)

* [inspector/expressions] remove root-level redirect to common (#136999) (#136997)

(cherry picked from commit 0596007)

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added v8.3.3 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 25, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 26, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 136999 locally

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kertal kertal kertal approved these changes

@jbudz jbudz jbudz approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@gbamparop gbamparop gbamparop approved these changes

@Dosant Dosant Dosant approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

backported release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Operations Kibana-Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.3.3 v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.