[expressions] remove root-level redirect, import from common#136997
Merged
spalger merged 6 commits intoelastic:mainfrom Jul 25, 2022
Merged
[expressions] remove root-level redirect, import from common#136997spalger merged 6 commits intoelastic:mainfrom
spalger merged 6 commits intoelastic:mainfrom
Conversation
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
botelastic
bot
added
Feature:Embedding
jbudz
approved these changes
Jul 22, 2022
spalger
force-pushed
the
fix/expressions/no-root-plugin-imports
branch
from
b25a2f2 to
475f750
Compare
nreese
reviewed
Jul 22, 2022
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-gis changes LGTM
code review
flash1293
approved these changes
Jul 25, 2022
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
VisEditors changes LGTM, code review only
ThomThomson
approved these changes
Jul 25, 2022
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Presentation team import changes LGTM! Code only review
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This comment was marked as outdated.
This comment was marked as outdated.
spalger
added
backport:prev-minor
and removed
backport:skip
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 25, 2022
…#136999) (elastic#136997) (cherry picked from commit 0596007)
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Merged backports with #137103 because of the files changed being so close |
spalger
pushed a commit
that referenced
this pull request
Jul 25, 2022
#136997) (#137103) * [inspector/expressions] remove root-level redirect to common (#136999) (#136997) (cherry picked from commit 0596007) * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the expressions plugin there is an
index.tsfile outside of theserver,public, andcommondirectories that just re-exports thecommonexports. In the package system this will need to be removed and the common package will need to be imported directly. Additionally, we're working to get a step closer to that state in #136911 and these changes were extracted from there so that we are importing the exact plugin-section we want.To accomplish this we used the
@kbn/eslint/module_migrationrule to remap all imports for@kbn/expressions-plugin(exactly) with@kbn/expressions-plugin/commonand removed the old index.ts file.