Upgrade EUI to v58.0.0 #132257

breehall · 2022-05-16T15:35:58Z

Added .render() calls to snapshot tests are intended to reduce the output of EUI components that use Emotion for styling. If you prefer the more verbose snapshot output in your plugin, we can remove the call.

`58.0.0`

Updated EuiForm to use forwardRef (#5866)
Updated all CSS-in-JS shadow functions parameters to match a (euiTheme, { color? }) order (#5892)
Updated euiShadow() parameters to (euiTheme, size, { color? }) (#5892)

Bug fixes

Fixed EuiContextMenuPanel (when used within an EuiPopover) to correctly return focus to its popover toggle in all scenarios, not just keyboard Escape press (#5880)
Fixed EuiSelectableTemplateSitewide to allow re-opening the search popover (if closed via Escape key) via the Enter key (#5886)
Fixed EuiComboBox by centering the enter badge in the list options. (#5890)
Fixed EuiTour position calculation issues caused by popover width styles (#5897)
Fixed EuiIcon from producing console warning in React.StrictMode (#5899)

`57.0.0`

Updated EuiMarkdownFormat to allow mailto: links by default (#5790)
Updated EuiMarkdownEditor's euiMarkdownLinkValidator parsing plugin to allow customization of link validation (#5790)
Added logicals{}, logicalCSS(), logicalStyle(), logicalTextAlignCSS(), and logicalTextAlignSTyle() CSS property utilities (#5850)
Added euiPaddingSize(), useEuiPaddingSize(), and useEuiPaddingCSS() sizing utilities (#5850)
Added euiBackgroundColor(), useEuiBackgroundColor() and useEuiBackgroundColorCSS() color utilities (#5850)
Changed default EuiCallOut heading element from span to p (#5870)
Updated EuiOverlayMask to accept a React ref (#5876)
Renamed user glyph to userAvatar in EuiIcon (#5877)
Added new user glyph in EuiIcon (#5877)

Bug fixes

Fixed alignment of EuiCallOut icon with the heading text (#5870)
Fixed EuiFlyout outsideClickCloses not being scoped to overlay mask when ownFocus=true (#5876)

Deprecations

Sass mixin euiCallOutColor() deprecated in favor of using EuiCallOut directly (#5870)

Breaking changes

Removed deprecated options for EuiDatePicker's popoverPosition props - use EuiPopover values going forward (#5868)
Removed partition prop from EuiCharts theme configuration - use theme.partition instead (#5868)
Removed data-grid-cell-id attribute from EuiDataGrid cells - use separate data-gridcell-column-id & data-gridcell-row-index attributes instead (#5868)
Removed noDivider prop from EuiFilterButton - use withNext prop instead (#5868)
Removed isSelected and isComplete props from EuiHorizontalStep - use status prop instead (#5868)
Removed isHollow prop from EuiStep - this visual appearance is no longer used in Amsterdam (#5868)
Removed condensed display prop from EuiTabs & EuiTabbedContent - this visual appearance is no longer used in Amsterdam (#5868)
Removed descriptionDisplay and labelDisplay props from EuiSuggestItem - use truncate and labelWidth instead, respectively (#5868)
Removed .euiButton---subdued className and $euiButtonTypes.subdued Sass variable - use text color instead (#5868)
Removed .eui-textOverflowWrap - use .eui-textBreakWord instead (#5868)
Removed .euiYScrollWithShadows - use .eui-yScrollWithShadows instead (#5868)
EuiMarkdownEditor no longer automatically includes the tooltip plugin in custom plugin arrays passed to uiPlugins. To use EUI's tooltip plugin, use getDefaultEuiMarkdownPlugins() (#5868)

CSS-in-JS conversions

Converted EuiLink to Emotion and removed $euiLinkColors (#5856)
Converted EuiCallOut to Emotion (#5870)

`56.0.0`

Increased weight of EuiLoadingSpinner border (#5845)
Added role and default aria-label to EuiLoadingLogo, EuiLoadingContent, EuiLoadingElastic, and EuiLoadingSpinner (#5845)
Added euiTextTruncate, euiTextWordBreak, and euiNumberFormat CSS-in-JS text utilities (#5854)
Added focus token to global EuiTheme (#5855)
Added euiFocusRing() and useEuiFocusRing() function/hook for customizing focus outline (#5855)
Added the focusTrapProps prop to EuiFlyout to aid outside click detection and closing event (#5860)

Bug fixes

Fixed a number of EuiMarkdownEditor's default toolbar buttons to highlight when the text cursor is in a related location (#5840)
Fixed allotted animation size of EuiLoadingLogo (#5845)
Fixed EuiLoadingElastic in dark mode (#5845)
Fixed border-radius of nested EuiSplitPanels (#5855)
Fixed offset of global focus outline (#5855)
Fixed EuiCollapsibleNav failing to close when the button is clicked (#5860)

CSS-in-JS conversions

Converted EuiBottomBar to Emotion (#5823)
Converted EuiHealth to Emotion (#5832)
Converted EuiTitle to Emotion (#5842)
Converted EuiLoadingLogo, EuiLoadingContent, EuiLoadingElastic, and EuiLoadingSpinner; Removed $euiLoadingSpinnerSizes, $euiGradientStartStop, and $euiGradientMiddle (#5845)
Converted EuiSkipLink to Emotion (#5851)

Breaking change

As part of EuiTitle's Emotion conversion, the line-height of s and xxs sized EuiTitles have been slightly reduced (#5842)

…ts for euiLink and euiTitle as they have been converted to Emotion

…alth, euiAvatar, euiSpacer, euiTitle, and euiLink as they have recently been converted to Emotion

… EuiSpacer, EuiText, EuiCallout, EuiHorizontalRule, EuiTitle, and EuiLink have been converted to Emotion. Updated the i18n translation snapshots

…rade-57.0.0 Pulling in the latest code from the main branch

…EuiLink, EuiTitle, EuiHorizontalRule, EuiSpace, and EuiCallout have been converted to Emotion

…as EuiLoader has been converted to Emotion

…Spacer, EuiHorizontalRule, Eui Callout, and EuiLink have been converted to Emotion

…Props prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed

…iDatePicket component with new / valid values. A list of values were deprecated and new values were added in EUI PR #5868 (elastic/eui#5868)

…condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868)

flash1293

VisEditors changes LGTM, only test adjustments for new element tree structure

estermv

Unified Observability changes LGTM

weltenwort

infra and monitoring plugin changes LGTM

x-pack/plugins/infra/public/pages/metrics/metric_detail/components/time_controls.test.tsx

breehall · 2022-06-06T14:05:00Z

@elasticmachine merge upstream

efegurkan

Enterprise Search changes approved.

No issues found on local build.

…into eui-upgrade-57.0.0 Pulling the latest code from upgrade branch

…sx. Restored snapshot

justinkambic

Synth/RUM changes LGTM

kibana-ci · 2022-06-07T20:27:53Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	356.4KB	356.4KB	+12.0B
`dataVisualizer`	535.8KB	535.8KB	-64.0B
`maps`	2.6MB	2.6MB	-12.0B
`ml`	3.3MB	3.3MB	+7.0B
`observability`	495.8KB	495.8KB	+12.0B
`osquery`	1.0MB	1.0MB	-31.0B
`rollup`	129.1KB	129.1KB	+36.0B
`securitySolution`	5.1MB	5.1MB	-17.0B
`snapshotRestore`	266.4KB	266.5KB	+140.0B
`triggersActionsUi`	810.8KB	810.9KB	+43.0B
total			+126.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	301.4KB	301.5KB	+110.0B
`esUiShared`	130.3KB	130.3KB	+20.0B
`kbnUiSharedDeps-css`	589.9KB	567.3KB	-22.6KB
`kbnUiSharedDeps-npmDll`	4.8MB	4.9MB	+36.5KB
total			+14.0KB

History

💔 Build #49701 failed 8284926
💚 Build #49351 succeeded c9a5555
💛 Build #48877 was flaky 82a7ec3
💚 Build #48745 succeeded 819e742
💔 Build #48718 failed 83ea64a
💔 Build #48714 failed ef9ab69

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dhurley14

security solution platform changes look good

tsullivan

app services changes LGTM

cnasikas

ResponseOps changes LTGM

peteharverson

ML edits LGTM

paul-tavares

Files in x-pack/plugins/security_solution/public/common/components/endpoint/* LGTM (on behalf of @elastic/security-onboarding-and-lifecycle-mgt team)

clintandrewhall · 2022-06-08T13:56:32Z

...d-ux/page/analytics_no_data/src/__snapshots__/analytics_no_data_page.component.test.tsx.snap

              <span
-                className="euiLoadingSpinner euiLoadingSpinner--medium"
-              />
+                aria-label="Loading"


The bloat here will need to be resolved on our end, either with a shallow render or a mock. cc: @majagrubic @sebelga

breehall added 2 commits May 16, 2022 11:24

Initial commit for EUI 57.0.0 upgrade

9f11487

Handle i18n changes

c59f8ce

breehall added release_note:skip Skip the PR/issue when compiling release notes EUI v8.3.0 labels May 16, 2022

cchaos added 8.4 candidate and removed v8.3.0 labels May 16, 2022

breehall added 15 commits May 16, 2022 15:55

Resolved type errors in DatePicker and Markdown Editor

95d2837

Resolve test failures in Jest Test Suite #1. Updated multiple snapsho…

cef5f1e

…ts for euiLink and euiTitle as they have been converted to Emotion

Resolved failing tests for Jest Suite #2. Updated snapshots for euiHe…

cb14466

…alth, euiAvatar, euiSpacer, euiTitle, and euiLink as they have recently been converted to Emotion

Resolved failing tests for Jest Suite 3. Updated failing snapshots as…

30f1b4a

… EuiSpacer, EuiText, EuiCallout, EuiHorizontalRule, EuiTitle, and EuiLink have been converted to Emotion. Updated the i18n translation snapshots

Merge branch 'main' of https://github.com/elastic/kibana into eui-upg…

8f0801c

…rade-57.0.0 Pulling in the latest code from the main branch

Upgrade EUI verion to 58.0.0

9bab6c1

Resolved tests failures from Jest Test Suite 4. Updated snapshots as …

d453882

…EuiLink, EuiTitle, EuiHorizontalRule, EuiSpace, and EuiCallout have been converted to Emotion

Resolved failing test cases for Jest Test Suite 5. Updated snapshots …

29c96fb

…as EuiLoader has been converted to Emotion

Resolved failing tests in Jest Test Suite 6. Updated snapshots as Eui…

b6d5494

…Spacer, EuiHorizontalRule, Eui Callout, and EuiLink have been converted to Emotion

Resolved type errors for EuiDatePicker component

0201fd5

Resolved type error within EuiContextMenu by removing the watchedItem…

16c308c

…Props prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed

Resolved type error within EuiContextMenu by removing the watchedItem…

bd52b5b

…Props prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed

Resolved type error within EuiContextMenu by removing the watchedItem…

f8a3e2e

…Props prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed

Resolved type errors by updating the popoverPlacement prop for the Eu…

125bcb8

…iDatePicket component with new / valid values. A list of values were deprecated and new values were added in EUI PR #5868 (elastic/eui#5868)

Resolved type error within EuiTabs by removing instances of display: …

796aeb2

…condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868)

cee-chen changed the title ~~Upgrade EUI to v57.0.0~~ Upgrade EUI to v58.0.0 May 24, 2022

cee-chen added v8.4.0 and removed 8.4 candidate labels May 24, 2022

cee-chen added 4 commits May 24, 2022 13:50

Merge branch 'main' into eui-upgrade-57.0.0

d6a2c64

Remove deprecated display prop from EuiTabs

07619a8

Deprecate .eui-textOverflowWrap

b4cde8f

Deprecate EuiSuggestItem labelDisplay prop

d26fc85

cee-chen force-pushed the eui-upgrade-57.0.0 branch from 9a3f8e7 to d26fc85 Compare May 24, 2022 21:15

flash1293 approved these changes Jun 2, 2022

View reviewed changes

weltenwort self-requested a review June 2, 2022 11:12

thompsongl added 2 commits June 2, 2022 09:24

revert doc_viewer_source test and snapshot changes

7558150

Merge branch 'main' into eui-upgrade-57.0.0

82a7ec3

estermv approved these changes Jun 3, 2022

View reviewed changes

weltenwort approved these changes Jun 3, 2022

View reviewed changes

x-pack/plugins/infra/public/pages/metrics/metric_detail/components/time_controls.test.tsx Show resolved Hide resolved

Merge branch 'main' into eui-upgrade-57.0.0

c9a5555

cee-chen mentioned this pull request Jun 6, 2022

[CSS-in-JS] Granular insertion; Utility component for classes elastic/eui#5853

Merged

10 tasks

efegurkan approved these changes Jun 7, 2022

View reviewed changes

opauloh mentioned this pull request Jun 7, 2022

[Session View] Update User icon to the new one #131101

Closed

breehall added 5 commits June 7, 2022 14:58

Resolve merge conflict, pull latest code from main

7434cf7

Merge branch 'eui-upgrade-57.0.0' of https://github.com/elastic/kibana …

8284926

…into eui-upgrade-57.0.0 Pulling the latest code from upgrade branch

Take care of merge conflict in license_checker:

7408d0b

Reverted .render() change for analytics_no_data_page.component.test.t…

867364e

…sx. Restored snapshot

Reverted .render() change for analytics_no_data_page.component.test.t…

ec1fbb1

…sx. Restored snapshot

justinkambic approved these changes Jun 7, 2022

View reviewed changes

dhurley14 approved these changes Jun 7, 2022

View reviewed changes

tsullivan approved these changes Jun 7, 2022

View reviewed changes

cnasikas approved these changes Jun 8, 2022

View reviewed changes

peteharverson approved these changes Jun 8, 2022

View reviewed changes

paul-tavares approved these changes Jun 8, 2022

View reviewed changes

clintandrewhall reviewed Jun 8, 2022

View reviewed changes

clintandrewhall approved these changes Jun 8, 2022

View reviewed changes

breehall merged commit b7c4d89 into main Jun 8, 2022

breehall deleted the eui-upgrade-57.0.0 branch June 8, 2022 14:18

kibanamachine added the backport:skip This PR does not require backporting label Jun 8, 2022

azasypkin mentioned this pull request Jun 22, 2022

Fix share to space flyout sizing #133949

Merged

nreese mentioned this pull request Aug 3, 2022

[Maps] Overflow of text outside tooltip border in Maps in Kibana 7.10.1 #87781

Closed

Upgrade EUI to v58.0.0 #132257

Upgrade EUI to v58.0.0 #132257

Uh oh!

Conversation

breehall commented May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

58.0.0

57.0.0

56.0.0

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

estermv left a comment

Choose a reason for hiding this comment

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

breehall commented Jun 6, 2022

Uh oh!

efegurkan left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jun 7, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

dhurley14 left a comment

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Jun 8, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

29 participants

breehall commented May 16, 2022 •

edited

Loading

`58.0.0`

`57.0.0`

`56.0.0`